From: sashiko-bot@kernel.org
To: "Kyle Switch" <kyle.switch@motor-comm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v20 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package
Date: Fri, 18 Sep 2026 13:15:05 +0000 [thread overview]
Message-ID: <20260918131505.AE5951F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917131441.3428554-2-kyle.switch@motor-comm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: unit-address mismatch with reg property in example
--
commit 21a69a542a09b6b2571122c2f9f0dadf390d6020
Author: Kyle Switch <kyle.switch@motor-comm.com>
dt-bindings: net: Document Motorcomm YT8824 PHY package
This commit introduces device tree binding documentation for the Motorcomm
YT8824 Ethernet PHY, describing it as a package of 4 PHYs.
> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
> new file mode 100644
> index 0000000000000..9737364744a07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
[ ... ]
> +examples:
> + - |
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet-phy-package@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "motorcomm,yt8824-package";
> + reg = <9>;
[Severity: Low]
Does this unit-address cause a validation warning during make
dt_binding_check? The node name uses @0, but the reg property is assigned
<9>. This mismatch typically triggers a unit_address_vs_reg warning from
the dtc compiler.
> +
> + phy-mode = "internal";
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917131441.3428554-1-kyle.switch@motor-comm.com?part=1
next prev parent reply other threads:[~2026-09-18 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 13:14 [PATCH net-next v20 0/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy Kyle Switch
2026-09-17 13:14 ` [PATCH net-next v20 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package Kyle Switch
2026-09-18 13:15 ` sashiko-bot [this message]
2026-09-21 13:17 ` netdev-bot+sashiko
2026-09-22 12:10 ` Andrew Lunn
2026-09-23 1:00 ` Kyle Switch
2026-09-17 13:14 ` [PATCH net-next v20 2/3] net: phy: Add support for Template Control register for PMA Kyle Switch
2026-09-18 13:15 ` sashiko-bot
2026-09-21 13:17 ` netdev-bot+sashiko
2026-09-17 13:14 ` [PATCH net-next v20 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy Kyle Switch
2026-09-21 13:17 ` netdev-bot+sashiko
2026-09-22 10:23 ` [PATCH net-next v20 0/3] " Paolo Abeni
2026-09-23 1:05 ` Kyle Switch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918131505.AE5951F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kyle.switch@motor-comm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox