Re: [PATCH 05/14] arm64: dts: apple: t8122: add avd nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: nodes not sorted by unit address in t8122
--

commit 3ed71c2496b1fa65386405608d5312e25564fcf0
Author: Sofus Forstreuter <sofus.c@icloud.com>

arm64: dts: apple: t8122: add avd nodes

This commit adds the AVD and AVD DART nodes to the Apple t8122 device tree.

> diff --git a/arch/arm64/boot/dts/apple/t8122.dtsi b/arch/arm64/boot/dts/apple/t8122.dtsi
> index 1ee61c5b3409f..992a7216b2edd 100644
> --- a/arch/arm64/boot/dts/apple/t8122.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8122.dtsi
> @@ -256,6 +256,30 @@ i2c4: i2c@2a1020000 {
>  			status = "disabled";
>  		};
>  
> +		avd: avd@289080000 {

[Severity: Low]
This isn't a functional bug, but should the avd and avd_dart nodes be placed in
ascending unit address order according to DT maintainer guidelines?

Currently, the avd node (unit address 0x289080000) is placed after the i2c4
node (unit address 0x2a1020000), which goes against the convention of sorting
nodes by unit address.

> +			compatible = "apple,t8122-avd";
> +			reg = <0x2 0x89080000 0x0 0x12000>,

[ ... ]

> +			power-domains = <&ps_avd_sys>;
> +			resets = <&ps_avd_sys>;
> +			iommus = <&avd_dart 0>;
> +		};
> +
> +		avd_dart: iommu@289010000 {

[Severity: Low]
This isn't a functional bug, but this avd_dart node (unit address 0x289010000)
should also likely be placed before the avd node (unit address 0x289080000) to
maintain ascending unit address ordering.

> +			compatible = "apple,t8122-dart", "apple,t8110-dart";
> +			reg = <0x2 0x89010000 0x0 0x4000>;
> +			#iommu-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-avd-v1-0-49977931f455@icloud.com?part=5