Re: [PATCH v4 2/8] ASoC: SDCA: export PM helpers keyed on sdca_class_drv

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] sdca_class: code and commit message mismatch for pm_ops export
--

commit 43543cd6fb0171b62979b93506768ae9a2b2e709
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

ASoC: SDCA: export PM helpers keyed on sdca_class_drv

The class PM callbacks pull sdca_class_drv out of drvdata, so the
built-in class_sdw_driver owns the drvdata slot. This blocks codec
drivers that want to embed sdca_class_drv in their own private struct.
Split the four callbacks into exported helpers that take a
struct sdca_class_drv * directly.

>     For the built-in class_sdw_driver, add small dev_pm_ops wrappers that
>     fetch drv from drvdata, wire them into sdca_class_pm_ops, and export
>     the ops so any generic SDCA slave can pick them up as-is.

> diff --git a/sound/soc/sdca/sdca_class.c b/sound/soc/sdca/sdca_class.c
> index d7444f442c71c..a092ebaa620aa 100644
> --- a/sound/soc/sdca/sdca_class.c
> +++ b/sound/soc/sdca/sdca_class.c
[ ... ]
> @@ -265,10 +283,37 @@ static int class_runtime_resume(struct device *dev)
[ ... ]
> -static const struct dev_pm_ops class_pm_ops = {
> -	SYSTEM_SLEEP_PM_OPS(class_suspend, class_resume)
> -	RUNTIME_PM_OPS(class_runtime_suspend, class_runtime_resume, NULL)
> +static const struct dev_pm_ops sdca_class_pm_ops = {
> +	SYSTEM_SLEEP_PM_OPS(class_pm_system_suspend, class_pm_system_resume)
> +	RUNTIME_PM_OPS(class_pm_runtime_suspend, class_pm_runtime_resume, NULL)
>  };

[Severity: Medium]
The commit message states that sdca_class_pm_ops is exported so generic
SDCA slaves can pick it up as-is, but it is defined statically here without
an export macro.

Will developers attempting to write a generic SDCA slave in another file
encounter build or linkage errors when trying to reference sdca_class_pm_ops?

Should this struct be exported to match the commit message description?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918131914.681588-1-srinivas.kandagatla@oss.qualcomm.com?part=2