Re: [PATCH v1 2/3] ASoC: qcom: qdsp6: lpass-ports: add support for QAIF AIF MI2S and TDM dais

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] qdsp6: reversed RX and TX slot masks for AIF_TDM DAIs
--

commit 055572fdc6d4e48c783378d1d4ba29423dfc1ef4
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

ASoC: qcom: qdsp6: lpass-ports: add support for QAIF AIF MI2S and TDM dais

This patch adds support for Qualcomm Audio Interface (QAIF) AIF MI2S and
TDM DAIs in the DAI driver. These DAIs are used in Shikra, Hawi, and Nord
based Qualcomm platform devices.

> diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> index e204fd59e5129..83f2711bceeaa 100644
> --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> @@ -386,6 +386,7 @@ static int q6tdm_set_tdm_slot(struct snd_soc_dai *dai,
>  
>  	switch (dai->id) {
>  	case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7:
> +	case AIF_TDM_RX_0 ... AIF_TDM_TX_12:
>  		slot_mask = (dai->id & 0x1) ? tx_mask : rx_mask;

[Severity: High]
Does this logic incorrectly flip the intended slot masks for the newly added
AIF_TDM DAIs?

The active mask is selected via the bitwise parity check (dai->id & 0x1).
For the legacy PRIMARY_TDM_RX_0 (24, even), this evaluates to 0 and correctly
selects rx_mask.

However, since AIF_TDM_RX_0 is defined as 179 (odd), wouldn't this evaluate
to 1 and incorrectly select tx_mask? Similarly, AIF_TDM_TX_0 is 180 (even)
and would incorrectly select rx_mask.

Could this fundamental mismatch result in zeroed or swapped slot masks,
leading to audio failure or dropped streams on these new TDM interfaces?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-qaif_dai_id_support-v1-0-ed863c0e5e45@oss.qualcomm.com?part=2