Re: [PATCH] dt-bindings: iio: adc: Add dt binding to xlnx,xadc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: missing required constraint for xlnx,external-mux-channel
- [Medium] dt-bindings: missing required constraint for #address-cells and #size-cells under xlnx,channels
--

commit 7f09f8169e0c3778bfd860a9b73695d153e538cf
Author: Omer PALA <palaomer100@gmail.com>

dt-bindings: iio: adc: Add dt binding to xlnx,xadc

This commit converts the text-based devicetree binding for the Xilinx 7
Series XADC and UltraScale/UltraScale+ System Monitor into YAML format.

> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
> new file mode 100644
> index 0000000000000..6031de7630a2c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
[ ... ]
> +  xlnx,channels:
> +    type: object
> +    description: List of external channels that are connected to the ADC.
> +    properties:
> +      "#address-cells":
> +        const: 1
> +      "#size-cells":
> +        const: 0
> +    patternProperties:

[Severity: Medium]
Should "#address-cells" and "#size-cells" be added to a required array for 
the xlnx,channels node? Without a required list here, schema validation 
might silently accept nodes that are missing these mandatory properties.

[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        xlnx,external-mux:
> +          const: single
> +    then:
> +      properties:
> +        xlnx,external-mux-channel:
> +          minimum: 0
> +          maximum: 16

[Severity: Medium]
Does this if-then block need a required declaration for 
xlnx,external-mux-channel? Currently, it only restricts the bounds of the 
property but doesn't mandate its presence when xlnx,external-mux is set to 
single. This could allow incomplete device trees to pass validation.

> +
> +  - if:
> +      properties:
> +        xlnx,external-mux:
> +          const: dual
> +    then:
> +      properties:
> +        xlnx,external-mux-channel:
> +          minimum: 1
> +          maximum: 8

[Severity: Medium]
Similarly, should xlnx,external-mux-channel be marked as required in this 
block when xlnx,external-mux is dual?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918145804.26957-1-palaomer100@gmail.com?part=1