Re: [PATCH 1/2] dt-bindings: arm64: fsl: add Olimex i.MX8MP boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: broken compatible string sequence for Olimex i.MX8MP
--

commit fac5462a0966914cfbc1e0773b00c8f06fddde88
Author: Zoltan HERPAI <wigyori@uid0.hu>

dt-bindings: arm64: fsl: add Olimex i.MX8MP boards

Document board compatible bindings for the Olimex i.MX8MP-SOM and
-EVB boards.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d53..aef15322293e1 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1146,6 +1146,8 @@ properties:
>                - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>                - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>                - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
> +              - olimex,imx8mp-som      # Olimex i.MX8MP-SOM
> +              - olimex,imx8mp-som-evb  # Olimex i.MX8MP-SOM-EVB

[Severity: Low]
Does adding the EVB string directly to this enum permit it to bypass the SoM
component string dependency? It seems this validates a 2-item sequence instead
of the standard 3-item sequence (Carrier -> SoM -> SoC) expected for SoM-based
carrier boards.

>                - prt,prt8ml             # Protonic PRT8ML
>                - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate

[ ... ]

> @@ -1225,6 +1227,11 @@ properties:
>            - const: kontron,imx8mp-osm-s               # Kontron i.MX8MP OSM-S SoM
>            - const: fsl,imx8mp
>  
> +      - description: Olimex i.MX8MP boards
> +        items:
> +          - const: olimex,imx8mp-som     # Olimex i.MX8MP-SOM
> +          - const: olimex,imx8mp-som-evb # Olimex i.MX8MP-SOM-EVB

[Severity: Low]
Does this block enforce a backwards 2-item sequence with the most specific
board listed last? 

Also, it appears the mandatory SoC fallback (fsl,imx8mp) is entirely omitted
here. Will this cause dt_binding_check or dtbs_check to fail when run on a
properly constructed 3-item compatible array?

> +
>        - description: PHYTEC phyCORE-i.MX8MP FPSC based boards
>          items:
>            - enum:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918195559.130443-1-wigyori@uid0.hu?part=1