Re: [PATCH v3 4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: regulator: ti,tps6586x: dt_binding_check failure
--

commit 73abdb102237b2babb6d5bfccbbceba8f14006bb
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

regulator: dt-bindings: ti,tps6586x: Convert to DT schema

Convert Texas Instruments tps6586x regulator binding from text to DT
schema. Reference to nvidia,tegra-regulators-coupling in child regulator
nodes.

> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> new file mode 100644
> index 0000000000000..1f7c7b35066f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> @@ -0,0 +1,196 @@
[ ... ]
> +          sys-supply = <&vdd_5v0_sys>;
> +          vin-sm0-supply = <&sys_reg>;
> +          vin-sm1-supply = <&sys_reg>;
> +          vin-sm2-supply = <&sys_reg>;
> +          vinldo01-supply = <&sm2_reg>;
> +          vinldo23-supply = <&sm2_reg>;
> +          vinldo4-supply = <&sm2_reg>;
> +          vinldo678-supply = <&sm2_reg>;
> +          vinldo9-supply = <&sm2_reg>;

[Severity: Low]
These properties reference phandle labels (&vdd_5v0_sys, &sys_reg, &sm2_reg)
that are not defined anywhere in the example snippet.

dtc throws a fatal 'Reference to non-existent node or label' error for
unresolved phandles during compilation.

Does this regression cause the example to fail make dt_binding_check?

> +
> +          regulators {
> +              sys {
> +                  regulator-name = "vdd_sys";
> +                  regulator-boot-on;
> +                  regulator-always-on;
> +              };
> +
> +              sm0 {
> +                  regulator-min-microvolt = < 725000>;
> +                  regulator-max-microvolt = <1500000>;
> +                  regulator-boot-on;
> +                  regulator-always-on;
> +              };
> +
> +              sm1 {
> +                  regulator-min-microvolt = < 725000>;
> +                  regulator-max-microvolt = <1500000>;
> +                  regulator-boot-on;
> +                  regulator-always-on;
> +              };
> +
> +              sm2 {
> +                  regulator-min-microvolt = <3000000>;

[Severity: Low]
The sys and sm2 child regulator nodes are missing the sys_reg: and sm2_reg:
labels that were present in the original text binding and are required to
resolve the internal phandle references.

Are these labels missing here?

> +                  regulator-max-microvolt = <4550000>;
> +                  regulator-boot-on;
> +                  regulator-always-on;
> +              };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-ti-tps6586x-v3-0-63dd240f4684@gmail.com?part=4