Re: [PATCH v7 3/3] arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R28S

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unused pinctrl definitions for wifi and bluetooth pins
--

commit 745cf672aded254ac32cf444a084e38df95384e1
Author: 安容 <HystericalDragons@proton.me>

arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R28S

This commit adds devicetree support for the NanoPi R28S router board based on
the RK3528 SoC. It shares most of its design with the NanoPi Zero2 and enables
various peripherals including SDIO, UART, and networking interfaces.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts
> new file mode 100644
> index 0000000000000..294b66f60e47b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts
[ ... ]
> +&pinctrl {
> +	bluetooth {
> +		bt_wake_host: bt-wake-host {
> +			rockchip,pins = <1 RK_PB5 RK_FUNC_GPIO &pcfg_pull_down>;
> +		};
> +
> +		host_wake_bt: host-wake-bt {
> +			rockchip,pins = <1 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};

[Severity: Low]
Are these bluetooth pinctrl nodes intended to be used or configured as hogs?
They are defined here but appear to never be referenced by any device node.
Without an explicit reference, such as a pinctrl-0 property on a device or
a hog definition, the configured pull states will not be applied.

[ ... ]
> +	wifi {
> +		host_wake_wl: host-wake-wl {
> +			rockchip,pins = <1 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		pwr_wf: pwr-wf {
> +			rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		wl_wake_host: wl-wake-host {
> +			rockchip,pins = <1 RK_PA7 RK_FUNC_GPIO &pcfg_pull_down>;
> +		};
> +	};
> +};

[Severity: Low]
Similarly, are the host_wake_wl and wl_wake_host nodes meant to be referenced
somewhere? Like the bluetooth pins, they are defined but do not seem to be
used by any device or set up as a hog, meaning their pull states will not take
effect.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-r28s-upstream-v7-0-e80a6f8ef521@proton.me?part=3