From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E44E92931F4; Sun, 20 Sep 2026 11:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789902348; cv=none; b=k4dWYSgFi7I0qaMBlyWvN6UFr5ksDivlFOhrleep6C9JItiwM8t3VRCBmQBkLTNF+ugVjjbNtdJmF3FcwKEkNODMbJ7HpiJ8PBtucx+E7/FeJh6TumAUghs/tLC0fCFWeiLm5ajpSppUKpXpe6hVpETip8ZjnaeVxY4pzgBEwaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789902348; c=relaxed/simple; bh=4yKi5j44FdLW/v3D8CZtfMpy25gM9vOjeSaVqEVGZDQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bCNrYERd93GiMJohW3PVSrewbWy3KRfLJGn+d8aoEM71m6gfX0liQ3bO0vnXOIznXLpXiy9rutBYYvcDdlsj3JpQdARtdO8r90Kql1v5zgjBciZfNlR70uLtPncCBITYrabyGynsiGaqmXMB0PtAT+vLUnqGzdfB+SgysATDpLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PUXQs3FY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PUXQs3FY" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9B47CC2BD00; Sun, 20 Sep 2026 11:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789902347; bh=4yKi5j44FdLW/v3D8CZtfMpy25gM9vOjeSaVqEVGZDQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=PUXQs3FYndIQKtzg0AqC+fpSkZ7vdxLQkFneDGq0dteOAEgRrbmVdtMVD+ktfB9cw stc4L+eBKxz4fSJlrOCVEXYp4q9uq5Uefun3FH+KGxBR8DgNx91cosr2LLQppaofLh kfNDgJwdFFoJbZrNpxd/AZRN/zXdIptp/onV/LT2dI/pe+AeZ9rv03Qr+dbPROv+Wm AFNTuaRfszkDRmgmN2lf1fQslWk+bPuQ04pvg7BZGFVoBpT3OMXZ1YHdGpJMRdJoiY K0qAQl2Xv9jydhwCP44xlwKUhBwNplgNPTfCeZ7gcvLJ3BMnDMoyMFhVIva9fKemNZ jwj7v1GT80Ilg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD56C982DA; Sun, 20 Sep 2026 11:05:47 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sun, 20 Sep 2026 13:05:46 +0200 Subject: [PATCH 03/11] drm/panel: s6e3ha8: Really assert reset on the failure Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260920-crosshatch-panel-v1-3-de6e9512da96@ixit.cz> References: <20260920-crosshatch-panel-v1-0-de6e9512da96@ixit.cz> In-Reply-To: <20260920-crosshatch-panel-v1-0-de6e9512da96@ixit.cz> To: Dzmitry Sankouski , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1389; i=david@ixit.cz; h=from:subject:message-id; bh=OzfdLbaebYlg4g6M/9ljeqwCz3P5UUikOpZwTfDJ7s0=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqr74IiMaZ7eLSG3j8Ye4MMpjqsDY0WqPVVnciA RGMdGMkZo+JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaq++CAAKCRBgAj/E00kg cn7QEACQA+ybHIvQR/Yu+E2AKsYzq8P5HZlmFlqdHwKT5AQioEW6jFpABsWBJ/uxVNOv32VGwSu ncr6ADDQsHfHJOBaipFhVHKDeDlFyG2iprIGXmhQiZOvd3FL3jfQTY0XbypWxJO3SdKc//0YI9g CzHkSK4boes7UYqZL0p428PuMd7Hd9hm+i9QfzVv9OlhIsvb4ZV/IE0S8jMenZZ8xNwcE14acKl QyA/ubpfJ8hRnKI+qdes+EPwSgpXI8WvBeeDNtjegucNlKDiG1PzlAwI5WAFOAiLjK2sMfE5aRp 9GP8WOxyMfT0+V2PCXPOgX7N5LvafeiIFuEahMxuG1awrYE5wYnUVrVh+VvmSWt+LAHcn8F8lMR +dq7DuJDS4OONC0qlCe4gmAcabPcqxqkF04IuxMy7YMfA15FKI/CRWtDy7G6qCtnZ+svkE+rYNe oGJs8iMLYJlTKByD195Xu4/ISCLOoHJZSdxoFI91dtfLtyfGY+YUDkk9ezxrUQFrPShs+AXDbV4 mPy2T9YP36Co5Owsgr5BB+s+9MQgg3TZSBnR+Wpbai8mS5yNSg1XbkxFzkKp+yJwoQNFgXNUeGh vSnHYxPOAhJM+cy5d0CM2KzbrlQQO+orvcl2Ga9ou0B1PRq5c6NJmVziKJeej4pA+1sxOeZW6RC HK6oY9OVFo7//vw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Due to incorrect implementation 0 == asserted, thus when driver fails it needs to assert reset. Minimal fix for stable; the polarity convention is corrected properly later in this series. Fixes: 779679d3c1640 ("drm/panel: Add support for S6E3HA8 panel driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c index 078523df48860..835121b322f4a 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c @@ -179,17 +179,17 @@ static int s6e3ha8_amb577px01_wqhd_prepare(struct drm_panel *panel) ret = regulator_bulk_enable(ARRAY_SIZE(s6e3ha8_supplies), priv->supplies); if (ret < 0) return ret; mipi_dsi_msleep(&ctx, 120); s6e3ha8_amb577px01_wqhd_reset(priv); ret = s6e3ha8_amb577px01_wqhd_on(priv); if (ret < 0) { - gpiod_set_value_cansleep(priv->reset_gpio, 1); + gpiod_set_value_cansleep(priv->reset_gpio, 0); goto err; } drm_dsc_pps_payload_pack(&pps, &priv->dsc); samsung_dsi_test_key_on_lvl1(&ctx); mipi_dsi_picture_parameter_set_multi(&ctx, &pps); samsung_dsi_test_key_off_lvl1(&ctx); -- 2.55.0