From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31B543F5BFC; Sun, 20 Sep 2026 11:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789902348; cv=none; b=NY4yuDi61NgfHt8BsNUtYTvCs/DbPAKbTB4x5c9mzJoZsMCgMLbUsdP3oHs/mjTnnGVgWfIrstCw34qsAoEijxM1/d/nXeL8sKBQQnZ9koPeV5WzZAwBcKluvZZUJqFk+2RQ2MFYYGa3mDk79Vbsk4bqf19/eFqJAwsvDMFYoZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789902348; c=relaxed/simple; bh=3H2pMXYIq5KO7FHqZw9wKd/DjXNREZNrATkmgbsSzwo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pjtv5aH0kJpNGZJlZ3WuvFDtXFiyn5ibMNauO0gbIUgmw//i2EKHzXuOlFGknKjZa4XGJ0Yv54N3wK8ujt46E6Ch8eeq/3oH+MVrnwbwzpD/9eFna8hBkAufGWkjL6rsgMyBcef709CgNmdIJv42EtMoru+NcLqKQc44kJ0grDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hRWhTX23; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hRWhTX23" Received: by smtp.kernel.org (Postfix) with ESMTPS id CBEBDC2BD01; Sun, 20 Sep 2026 11:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789902347; bh=3H2pMXYIq5KO7FHqZw9wKd/DjXNREZNrATkmgbsSzwo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=hRWhTX23NXNkuPWkr5arhFxyy8SeEqKbzqQnhBXWozEYIfG/CbBXwNaJkU1KS8YQh mq/l1Y2n6tN6QYctE40Kbm6CjpaELubsfXiR8Z57/zt1FIVhCP+IESM8ysMXYqwUbr 1K2MuvvH/oD/WoGvskXpIzcsPyuWMMFY0Ugb1KvDO23MWcsNtZP5vnDRISaQXGfR3X +gACvLWdN7dLeXcBtnqjS04dkQLi0ONmjpyrKKoJ2m0hWUT4AE1K7dgQyO8lG2aNDB bl7vCn6PrtW5PHal02LdGGnebIyeTJvqqpHAnH/6HWF1rutrKlF1AtOJ8UOfzDu3UT tfjXFrZBjxhKg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B954BC982EA; Sun, 20 Sep 2026 11:05:47 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sun, 20 Sep 2026 13:05:49 +0200 Subject: [PATCH 06/11] drm/panel: s6e3ha8: Correct the polarity logic within Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260920-crosshatch-panel-v1-6-de6e9512da96@ixit.cz> References: <20260920-crosshatch-panel-v1-0-de6e9512da96@ixit.cz> In-Reply-To: <20260920-crosshatch-panel-v1-0-de6e9512da96@ixit.cz> To: Dzmitry Sankouski , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5025; i=david@ixit.cz; h=from:subject:message-id; bh=AsLGrTHDZPEXKoKc7cmkn4LGk3BpbMWpzP4RRT1AZKs=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqr74Ik6jhQIxCLyINs++12HHsExGaAdOsDegp9 L3eRwdp4PiJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaq++CAAKCRBgAj/E00kg chc4D/9MAFz1chlHPHhVV9Zy+6nXJddT5EHau7i7jDCaFiuCat2ElNMGPTpLPko+NtOQoUlRJGb 9Cz2HDCbuu1O9J/kjCn33uFpzk3XRai19Rf8VpGqXEgR7LQQ0+LXp6RKAYiO6MFvoPCTrt+wia1 kvinZcNseQXGo+rSwcmHx4MKz/DjxR6A7BDz/V9iJd98FNw4A/VHw5b2Qe737XHPjMWmmGN25mT uc0CpDQbTexTP5fkccvJ5GkaX10HVPuB5YV0w/f5/mmkKuMnrs7IQtWccJ5KmLgenKOMzPcydr4 LvUC1v5Lm9nWO1AuXWo9JC0/rU6rTuWbyC6Eirby1oYSn+QyNwDGU1uRkpYicZsGwv+P0r1KTDL Pt2mXvNjPn1xXOjbA+cRwL1bGejDxLHPnXdJoUvFeRcVxmsD8U4g9NXX6T++3NLQO1DkHerpQ37 42NfTJ4qLqgIckII8UzLgbl87Nc6exFAreo9ga6mBGq/HZ6TwsgVRmOEd9y1hUoa4yjgT/O9J7T kh+igfAjcMAMDRUP1eU5sz47yvEs/VV/kXDa6et1UCvjddyofb6SWuPLpOJXB+NS7ftbg9xT6X5 ZPHWXBIr61wM6WFiyxbJJPcQGfOh/lG1xfoUGC61WsAoc46pHK2AXLSrg5Z6/aqquUeDohPzL6w uNMOfsubDkNOxYQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The reset was introduced with wrong polarity. Correct for the future compatibles and keep current with reverted logic. Old DTs keep GPIO_ACTIVE_HIGH and are fixed up via gpiod_toggle_active_low() on the deprecated compatible. Assisted-by: LLM Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c index 5e1e997b83b36..99290913de69a 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c @@ -20,16 +20,17 @@ #include "panel-samsung-dsi.h" struct s6e3ha8_desc { const struct drm_panel_funcs *funcs; const struct drm_display_mode *mode; unsigned long mode_flags; const struct regulator_bulk_data *supplies; unsigned int num_supplies; + bool broken_reset_polarity; }; struct s6e3ha8 { struct drm_panel panel; struct mipi_dsi_device *dsi; const struct s6e3ha8_desc *desc; struct drm_dsc_config dsc; struct gpio_desc *reset_gpio; @@ -62,22 +63,22 @@ static int s6e3ha8_unprepare(struct drm_panel *panel) { struct s6e3ha8 *priv = to_s6e3ha8(panel); return regulator_bulk_disable(priv->desc->num_supplies, priv->supplies); } static void s6e3ha8_amb577px01_wqhd_reset(struct s6e3ha8 *priv) { - gpiod_set_value_cansleep(priv->reset_gpio, 1); - usleep_range(5000, 6000); gpiod_set_value_cansleep(priv->reset_gpio, 0); usleep_range(5000, 6000); gpiod_set_value_cansleep(priv->reset_gpio, 1); usleep_range(5000, 6000); + gpiod_set_value_cansleep(priv->reset_gpio, 0); + usleep_range(5000, 6000); } static int s6e3ha8_amb577px01_wqhd_on(struct s6e3ha8 *priv) { struct mipi_dsi_device *dsi = priv->dsi; struct mipi_dsi_multi_context ctx = { .dsi = dsi }; dsi->mode_flags |= MIPI_DSI_MODE_LPM; @@ -203,17 +204,17 @@ static int s6e3ha8_amb577px01_wqhd_prepare(struct drm_panel *panel) ret = regulator_bulk_enable(priv->desc->num_supplies, priv->supplies); if (ret < 0) return ret; mipi_dsi_msleep(&ctx, 120); s6e3ha8_amb577px01_wqhd_reset(priv); ret = s6e3ha8_amb577px01_wqhd_on(priv); if (ret < 0) { - gpiod_set_value_cansleep(priv->reset_gpio, 0); + gpiod_set_value_cansleep(priv->reset_gpio, 1); goto err; } drm_dsc_pps_payload_pack(&pps, &priv->dsc); samsung_dsi_test_key_on_lvl1(&ctx); mipi_dsi_picture_parameter_set_multi(&ctx, &pps); samsung_dsi_test_key_off_lvl1(&ctx); @@ -243,16 +244,27 @@ static const struct drm_display_mode s6e3ha8_amb577px01_wqhd_mode = { static const struct drm_panel_funcs s6e3ha8_amb577px01_wqhd_panel_funcs = { .prepare = s6e3ha8_amb577px01_wqhd_prepare, .unprepare = s6e3ha8_unprepare, .get_modes = s6e3ha8_get_modes, .enable = s6e3ha8_amb577px01_wqhd_enable, .disable = s6e3ha8_amb577px01_wqhd_disable, }; +static const struct s6e3ha8_desc s6e3ha8_amb577px01_wqhd_desc_legacy = { + .funcs = &s6e3ha8_amb577px01_wqhd_panel_funcs, + .mode = &s6e3ha8_amb577px01_wqhd_mode, + .mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS | + MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | + MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET, + .supplies = s6e3ha8_vddr_supplies, + .num_supplies = ARRAY_SIZE(s6e3ha8_vddr_supplies), + .broken_reset_polarity = true, +}; + static const struct s6e3ha8_desc s6e3ha8_amb577px01_wqhd_desc = { .funcs = &s6e3ha8_amb577px01_wqhd_panel_funcs, .mode = &s6e3ha8_amb577px01_wqhd_mode, .mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET, .supplies = s6e3ha8_vddr_supplies, .num_supplies = ARRAY_SIZE(s6e3ha8_vddr_supplies), @@ -283,16 +295,19 @@ static int s6e3ha8_probe(struct mipi_dsi_device *dsi) return ret; } priv->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(priv->reset_gpio)) return dev_err_probe(dev, PTR_ERR(priv->reset_gpio), "Failed to get reset-gpios\n"); + if (priv->desc->broken_reset_polarity) + gpiod_toggle_active_low(priv->reset_gpio); + priv->dsi = dsi; mipi_dsi_set_drvdata(dsi, priv); dsi->lanes = 4; dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = priv->desc->mode_flags; priv->panel.prepare_prev_first = true; @@ -323,17 +338,17 @@ static int s6e3ha8_probe(struct mipi_dsi_device *dsi) return 0; } static const struct of_device_id s6e3ha8_of_match[] = { { /* deprecated */ .compatible = "samsung,s6e3ha8", - .data = &s6e3ha8_amb577px01_wqhd_desc, + .data = &s6e3ha8_amb577px01_wqhd_desc_legacy, }, { .compatible = "samsung,s6e3ha8-amb577px01", .data = &s6e3ha8_amb577px01_wqhd_desc, }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, s6e3ha8_of_match); -- 2.55.0