From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 343D03F660E; Sun, 20 Sep 2026 11:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789902348; cv=none; b=qx+gg2HtKUv6RTWGCa/6vNHEsdzrqKj/CqtN67rKpNrdmfo3QvpMUkyc29l9Nm2+lMeY4REUHabBhVF/bPoUI9PNVrwZm5HLDXsxV4Eq6X107hdCiCH9vDVaR9fFYZkuEjEKBdt9TeIw7hv+K5SsdKhvaTJxYwXM2sA8DOXoxaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789902348; c=relaxed/simple; bh=ieVb6H735tCmYSLUV9i+yDFAU2NPi3u6MYYeNLsO/Tg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cVpvMNbevH4hUKOHunVwMzsSOwXzDqA6rLuacn/R9gTJoV+foywYlkXeyBNLU7u0RLtu6ar9m1UYADCakbc7aCGmNch2SHZbtu5YClzz5UjExG2C4klCkyRRsiUAkjdu+Enl+yQBYtX0OcOAjx5gy466AuHQjZwpJgwGiR9OeUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bbLqzdlU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bbLqzdlU" Received: by smtp.kernel.org (Postfix) with ESMTPS id DC629C2BCFA; Sun, 20 Sep 2026 11:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789902347; bh=ieVb6H735tCmYSLUV9i+yDFAU2NPi3u6MYYeNLsO/Tg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=bbLqzdlUuZoRyvHWhykwfg8Eptt9k/QEyG5E8Tr+dJmg1l+TQxJBCHZjks/eIGC9T 1+HzMaSdtYVepOdozabFPGdvnOLoqZKcl6PL1X6f4+45sNAS1YcVQb3sNnZN3CzvbL LSyishR0w/0Pj/fUHdluOqY9NairvA4/3HRhaDBUvYAXAC6Ab7ii0F3HiiwHDnq9O0 r8uT3YO5FOYpMcGhQA7TC58i5ws3naO3AJDjQWO0m2Ea54mGKoR0//lXl69xHrJA+q 2ZGKA3iEh1u5K8xLNxCkneRm9T5NMt9yWdpodLkYngdMaYV/7cWQ60GORCf9HX9D0k 8Bexmla3HQ7+A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3A8C982EB; Sun, 20 Sep 2026 11:05:47 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sun, 20 Sep 2026 13:05:50 +0200 Subject: [PATCH 07/11] drm/panel: s6e3ha8: Assert reset GPIO in unprepare Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260920-crosshatch-panel-v1-7-de6e9512da96@ixit.cz> References: <20260920-crosshatch-panel-v1-0-de6e9512da96@ixit.cz> In-Reply-To: <20260920-crosshatch-panel-v1-0-de6e9512da96@ixit.cz> To: Dzmitry Sankouski , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1090; i=david@ixit.cz; h=from:subject:message-id; bh=20U0ozvap504c/y7dNH03jLGzPdtj7FO3ci7Ov7l9BM=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqr74JI29ZlFwOBeivI0xUK4KNDr/fR/lUt5sf2 hCXgwI+aeqJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaq++CQAKCRBgAj/E00kg cgMTEACRs0Ec5QPTNCucUsDUMH1a7vXMyWNR1q0yN2AJ8JYiGI7kOInveX4aUpekPi4Y8fgGaRe 7zMV2r9Hmnt/dZb01vKzEuy0iOiho28I0qeAbu6moijMbG3zNn6zgeP1ygAfUbKtzpdOoS+kZRf isTe/tSQpKqmAkxi6DPrPpZRzOl7eb4aKXJ9/E/NyTUJH8/KYe5pTCjxuc3s28tyYnbFx+E0zH/ oB9eCLwYVrMYMbM3yHcjLQnavaD/X26gUmsw7yBpzSLX59pGrM8dx6+tMD3ALQIWhaCSBFse1uu 1TL4xCnRaOphcsDC1QR0waG1iqp2i8mw4DD7KJIIx54eFv3k+8vFiZFo4CqJG4skI+KSLSs9Zu0 aSBfvZXEUCFJya1ep499H3HopH4FgxGqq8tjeNYIR7dRrb9hFq1e5TbQNSuWYsugbaAy6uttxdE 62uZa5QU8wmJSB4CamU8BiwPR52NV75vZ/O/mY9s2dRN0ApJsPWnhmo1pD50pmLuII4ByBimWWw MdnrlnTY4tNcfaHN171klb7yTJF2kiHu0hWEaPhEkXXgPB44CO3WcaK9nP6aN2H19rcppaGjxLP igf3oXxaie0G1r9LwYFd7on0npkjUfM/HBx090E+QjsUVeuG3kXPcUOuML7osXYMbrXT7FA7n08 d+KAl0IMaUBl6mA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg For correct shutdown, the reset should be asserted. Assisted-by: LLM Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c index 99290913de69a..2591b8c1a7753 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c @@ -58,16 +58,17 @@ static int s6e3ha8_get_modes(struct drm_panel *panel, return drm_connector_helper_get_modes_fixed(connector, priv->desc->mode); } static int s6e3ha8_unprepare(struct drm_panel *panel) { struct s6e3ha8 *priv = to_s6e3ha8(panel); + gpiod_set_value_cansleep(priv->reset_gpio, 1); return regulator_bulk_disable(priv->desc->num_supplies, priv->supplies); } static void s6e3ha8_amb577px01_wqhd_reset(struct s6e3ha8 *priv) { gpiod_set_value_cansleep(priv->reset_gpio, 0); usleep_range(5000, 6000); gpiod_set_value_cansleep(priv->reset_gpio, 1); -- 2.55.0