Re: [PATCH 1/1] riscv: dts: spacemit: set ETH MAC from eeprom for OrangePi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: removing standard aliases to bypass bootloader behavior
--

commit 8bb8e326a73a3935458461c280ad331fa5713466
Author: Chukun Pan <amadeus@jmu.edu.cn>

riscv: dts: spacemit: set ETH MAC from eeprom for OrangePi

This commit configures the OrangePi R2S and RV2 device trees to read
the Ethernet MAC address from an EEPROM. It also removes the ethernet0
and ethernet1 aliases to prevent U-Boot from patching the MAC address
incorrectly.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> index 7125f2882ce85..073cc975135f4 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> @@ -16,8 +16,6 @@ aliases {
>  		i2c2 = &i2c2;
>  		i2c8 = &i2c8;
>  		serial0 = &uart0;
> -		ethernet0 = &eth0;
> -		ethernet1 = &eth1;

[Severity: Medium]
Is it appropriate to remove these standard network aliases to bypass a
bootloader limitation? 

The device tree is intended to accurately describe the hardware structure
independent of bootloader software bugs or workarounds. Removing standard
aliases can disrupt predictable network interface naming and standard device
enumeration. 

As stated in the commit message, this change is made solely to avoid U-Boot
patching incorrect MAC addresses. Modifying an OS device tree to hack around
bootloader limitations, such as U-Boot's fdt_fixup_ethernet, is generally
considered an anti-pattern. 

Could this be addressed by changing U-Boot's configuration for this board
instead?

>  	};
>  
>  	chosen {

[ ... ]

> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> index 837616255464a..609c4755775df 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> @@ -15,8 +15,6 @@ / {
>  
>  	aliases {
>  		serial0 = &uart0;
> -		ethernet0 = &eth0;
> -		ethernet1 = &eth1;

[Severity: Medium]
Does removing these aliases here also risk disrupting predictable network
interface naming for the OS? 

As mentioned above, it might be safer to fix the U-Boot configuration
rather than omitting standard hardware aliases in the OS device tree.

>  		i2c2 = &i2c2;
>  		i2c8 = &i2c8;
>  		mmc0 = &emmc;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920100000.3888256-1-amadeus@jmu.edu.cn?part=1