From: sashiko-bot@kernel.org
To: "Viken Dadhaniya" <viken.dadhaniya@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller
Date: Sun, 20 Sep 2026 12:12:50 +0000 [thread overview]
Message-ID: <20260920121250.8E6E81F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260920-i2c-qcom-slave-v4-1-f7e1020f3bb4@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: i2c: qcom,qdu1000-i2c-target lacks i2c-controller schema ref
--
commit 04d5fcf83b820d8d116604eccea697fd3f7a8e35
Author: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
dt-bindings: i2c: Add Qualcomm I2C target controller
This commit adds a new devicetree binding for the dedicated Qualcomm I2C
target controller used in QDU1000 and related SoCs.
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml b/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml
> new file mode 100644
> index 0000000000000..9a6b08f0ab0e7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/qcom,qdu1000-i2c-target.yaml
[ ... ]
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - interconnects
> +
> +additionalProperties: false
[Severity: Medium]
Does this strict additionalProperties rule block the addition of valid I2C
target backend child nodes?
In the Linux I2C subsystem, target (slave) backends like EEPROM emulators or
MCTP endpoints are described as child nodes of the I2C controller. The driver
calls i2c_add_adapter() with the controller's of_node, which naturally
parses these child nodes.
Because this binding omits a reference to /schemas/i2c/i2c-controller.yaml#,
it does not define #address-cells or #size-cells. When a devicetree developer
attempts to add a child node with a reg property for the slave address, schema
validation will reject it.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-i2c-qcom-slave-v4-0-f7e1020f3bb4@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-20 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 12:04 [PATCH v4 0/2] Add Qualcomm I2C target controller driver Viken Dadhaniya
2026-09-20 12:04 ` [PATCH v4 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller Viken Dadhaniya
2026-09-20 12:12 ` sashiko-bot [this message]
2026-09-20 12:04 ` [PATCH v4 2/2] i2c: qcom-target: Add driver for " Viken Dadhaniya
2026-09-20 12:17 ` sashiko-bot
2026-09-29 6:51 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920121250.8E6E81F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox