Devicetree
 help / color / mirror / Atom feed
From: Linus Walleij <linusw@kernel.org>
To: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	 Linus Walleij <linusw@kernel.org>
Subject: [PATCH 1/2] dt-bindings: display: faraday,tve200: Use a level-high interrupt
Date: Mon, 21 Sep 2026 11:15:54 +0200	[thread overview]
Message-ID: <20260921-gemini-tve200-fix-v1-1-8be03ac2a8f7@kernel.org> (raw)
In-Reply-To: <20260921-gemini-tve200-fix-v1-0-8be03ac2a8f7@kernel.org>

The TVE200 vertical interrupt can remain pending after acknowledgment.
Using rising-edge triggering can leave it unserviced when no new edge
is generated, causing vblank and page-flip timeouts on the D-Link DIR-685.

Use level-high triggering in the binding example so a pending interrupt
is delivered again without requiring a new edge.

Fixes: 8b17e80d9e46 ("drm/tve200: Add DT bindings")
Assisted-by: LLM
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
 Documentation/devicetree/bindings/display/faraday,tve200.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/faraday,tve200.yaml b/Documentation/devicetree/bindings/display/faraday,tve200.yaml
index b09628b69177..43dbe2778d6b 100644
--- a/Documentation/devicetree/bindings/display/faraday,tve200.yaml
+++ b/Documentation/devicetree/bindings/display/faraday,tve200.yaml
@@ -54,7 +54,7 @@ examples:
     display-controller@6a000000 {
       compatible = "faraday,tve200";
       reg = <0x6a000000 0x1000>;
-      interrupts = <13 IRQ_TYPE_EDGE_RISING>;
+      interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
       resets = <&syscon GEMINI_RESET_TVC>;
       clocks = <&syscon GEMINI_CLK_GATE_TVC>,
                <&syscon GEMINI_CLK_TVC>;

-- 
2.55.0


  reply	other threads:[~2026-09-21  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  9:15 [PATCH 0/2] Fix Gemini TVE200 interrupt triggering Linus Walleij
2026-09-21  9:15 ` Linus Walleij [this message]
2026-09-27 17:42   ` [PATCH 1/2] dt-bindings: display: faraday,tve200: Use a level-high interrupt Krzysztof Kozlowski
2026-09-28 13:17   ` Rob Herring (Arm)
2026-09-28 13:19     ` Linus Walleij
2026-09-21  9:15 ` [PATCH 2/2] ARM: dts: gemini: Use a level-high interrupt for TVE200 Linus Walleij
2026-09-21  9:25   ` sashiko-bot
2026-09-22 12:16     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921-gemini-tve200-fix-v1-1-8be03ac2a8f7@kernel.org \
    --to=linusw@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox