Re: [RFC PATCH v3 2/3] Bluetooth: dt-bindings: Add AIC8800D80

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: unsatisfiable constraint on reg property causes validation failure
--

commit c2a5ac7736c6234041d0e5fd1d5e6d9742fc0653
Author: Yanli Yang <yanli.yang@bedmex.com>

Bluetooth: dt-bindings: Add AIC8800D80

This commit adds the device tree binding for the AIC8800D80 Bluetooth SDIO
and UART HCI interface. It describes the firmware-loading function and links
the UART node to the SDIO firmware provider. It also updates the MAINTAINERS
file.

> diff --git a/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml
> new file mode 100644
> index 0000000000000..9c04ba62ecefd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml

[ ... ]

> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          const: aic,aic8800d80-bt-sdio
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - const: 1

[Severity: Low]
Does this constraint on the reg property cause a validation failure?

In dt-schema, the reg property is always decoded as a matrix (an array of
arrays), even for single-cell values. For example, reg = <1> in the provided
example is parsed internally as [[1]].

Because JSON Schema evaluates this by checking if the first element of the
outer array exactly matches the literal integer 1, this constraint is
impossible to satisfy and causes make dt_binding_check to unconditionally
fail.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1789974593.git.yanli.yang@bedmex.com?part=2