Devicetree
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Andre Gilerson <andre.gilerson@gmail.com>,
	Dan Scally <dan.scally@ideasonboard.com>
Cc: Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	German Pablo Lindo <germanpapulindez@gmail.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/3] Add support for the Sony IMX681 camera sensor
Date: Mon, 21 Sep 2026 19:24:56 +0000	[thread overview]
Message-ID: <20260921192450.21811-1-lsa.uz@pm.me> (raw)

The Sony IMX681 is the user-facing camera on the Microsoft Surface Pro 11 for
Business (Intel Lunar Lake, IPU7), ACPI device SONY0681. Without a driver the
camera does not appear at all.

  1/3  dt-bindings: media: Add Sony IMX681            (mine)
  2/3  media: i2c: Add Sony IMX681 sensor driver      (Andre Gilerson's)
  3/3  media: ipu-bridge: Add Sony IMX681             (mine)

The driver is Andre's work, reverse-engineered from I2C traces taken under
Windows. I am carrying the submission, not the code.

Changes in v5
=============

v4 does not compile on aedd77ea8168, the base it declares. .set_fmt and
.get_selection gained a const v4l2_subdev_client_info *ci argument between
b38d06ad1e13 and that commit; v4 was rebased across the window and 2/3 was
carried unchanged. v5 adds the argument, two lines, and differs from v4 in
nothing else. Krzysztof's Reviewed-by on 1/3 and German's Tested-by on 2/3
stand.

It took building the series to see it: git apply reports no offset on v4
even now, and checkpatch passes it.

Checked
=======

Built into a kernel from this series and booted on the machine. 2/3's
imx681.c and the file that built the running module hash to the same bytes.

  intel-ipu7: Found supported sensor SONY0681:00 (\_SB.PC00.I2C5.CAMF)

  v4l2-compliance 1.32.0 on the sensor subdev:
  Total for device /dev/v4l-subdev5: 46, Succeeded: 46, Failed: 0, Warnings: 0

checkpatch --strict, sparse and W=1 are clean on 2/3 and 3/3; 1/3's only
warning asks whether MAINTAINERS needs updating, which 2/3 does.

v4's limitations are unchanged and still hold: one machine, one sensor
sample, one mode (3844x2640 SGRBG10 at 969.6 MHz per lane), dummy dvdd and
dovdd from INT3472 so the fatal regulator path is reasoned rather than
exercised, no IVSC HID present, and no KASAN or lockdep build.

Still open, as in v4: Andre's ack on the binding, which Krzysztof asked for
and which is properly Andre's. And the mirroring question raised against v3.

Based on media/next at aedd77ea8168 ("media: qcom: camss: use
fwnode_graph_for_each_endpoint_scoped() to simplify code"). That branch
rewinds, so if this does not apply where you are, say so and I will rebase -
and build it afterwards this time.

German reported this HID as a bug on this list on 3 September and has had no
reply since; he is on Cc here.

  https://lore.kernel.org/linux-media/20260903080854.16266-1-germanpapulindez@gmail.com/
-- 
2.54.0 (Apple Git-157)


             reply	other threads:[~2026-09-21 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 19:24 Sergey Lebedev [this message]
2026-09-21 19:25 ` [PATCH v5 1/3] dt-bindings: media: Add Sony IMX681 Sergey Lebedev
2026-09-21 19:25 ` [PATCH v5 2/3] media: i2c: Add Sony IMX681 sensor driver Sergey Lebedev
2026-09-21 19:38   ` sashiko-bot
2026-09-22  9:04   ` Sakari Ailus
2026-09-21 19:25 ` [PATCH v5 3/3] media: ipu-bridge: Add Sony IMX681 Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921192450.21811-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=andre.gilerson@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=germanpapulindez@gmail.com \
    --cc=hansg@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox