Re: [PATCH v5 1/6] dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: pci: missing phys requirement for Gen5 PCIe
- [Medium] dt-bindings: pci: missing minItems allows incomplete reg arrays to pass validation
--

commit 514029652899ad708ecb1a48b34db8779da18327
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>

dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible

Document bindings for R-Car X5H (R8A78000) PCIe4 host module. The commit
introduces the "renesas,rcar-gen5-pcie4" compatible string and adjusts the
"reg" and "reg-names" constraints, as the PHY is now a separate IP for Gen5.

> diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> index 64f456c6a75a1..9767a52f3904e 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml

[ ... ]

> @@ -84,6 +74,46 @@ required:
>    - resets
>    - reset-names
>  
> +allOf:
> +  - $ref: snps,dw-pcie.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,rcar-gen4-pcie
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 7

[Severity: Medium]
By moving the "reg" and "reg-names" properties into this allOf conditional
block, does this bypass the automatic array length constraint inference from
dt-schema?

Without an explicit "minItems: 7" constraint here, it looks like the schema
will fall back to inheriting "minItems: 2" from the base schema in
snps,dw-pcie.yaml#. Could this allow a device tree node with only two
registers (like "dbi" and "config") to incorrectly pass validation?

> +
> +        reg-names:
> +          items:
> +            - const: dbi
> +            - const: dbi2
> +            - const: atu
> +            - const: dma
> +            - const: app
> +            - const: phy
> +            - const: config
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,rcar-gen5-pcie4
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 6

[Severity: Medium]
Similarly to the Gen4 conditional above, does this Gen5 block need an
explicit "minItems: 6" constraint to prevent truncated register arrays from
passing validation?

Also, the commit message mentions that the R-Car X5H PCIe4 controller no
longer includes the PHY register range and that the PHY is now referenced
via the "phys" DT property. Since the driver requires this external PHY to
be present, should "phys" be added to a "required" list within this Gen5
conditional block so that incomplete device tree nodes fail validation?

> +
> +        reg-names:
> +          items:
> +            - const: dbi
> +            - const: dbi2
> +            - const: atu
> +            - const: dma
> +            - const: app
> +            - const: config

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921202823.72620-1-marek.vasut+renesas@mailbox.org?part=1