Re: [PATCH] dt-bindings: mfd: Allow MT6360 interrupt flags

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: #interrupt-cells uses enum instead of required const constraint
--

commit 3c231e0793c5c72fac7dc860b2b89ed70228f7a3
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: mfd: Allow MT6360 interrupt flags

This commit updates the MT6360 device tree binding to allow the interrupt
controller to use either one or two cells. It replaces the constant cell
count constraint with an enum to support an optional second cell for
trigger flags.

> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> index fb65abf30d57b..828ed7f558f66 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> @@ -33,9 +33,10 @@ properties:
>    interrupt-controller: true
>  
>    "#interrupt-cells":
> -    const: 1
> +    enum: [1, 2]

[Severity: Medium]
Does this change conflict with the device tree binding subsystem rules? 

The subsystem guidelines mandate that cell-count properties like
#interrupt-cells must use a const constraint rather than an enum to prevent
ambiguous or variable cell sizes during schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232701.3133291-1-robh@kernel.org?part=1