Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: Add dedicated CM32181 schema
Date: Mon, 21 Sep 2026 23:36:09 +0000	[thread overview]
Message-ID: <20260921233609.C4DDC1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921232752.3136129-1-robh@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect use of unevaluatedProperties
--

commit 8c1995822038b741ca98711a9ec628a88e937b63
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: iio: Add dedicated CM32181 schema

This commit adds a dedicated Capella CM32181 ambient light sensor schema.
It moves the device out of trivial-devices to properly document its optional
vdd-supply and interrupt properties.

> diff --git a/Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml b/Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml
> new file mode 100644
> index 0000000000000..63212e3ec96ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false

[Severity: Low]
Does this schema violate the DT authoring guidelines by using
unevaluatedProperties here? 

Since the schema for capella,cm32181 does not reference any external base
schemas (there is no $ref keyword present), should this use
additionalProperties: false instead? 

Using unevaluatedProperties without any referenced base schemas is less
efficient and diverges from the standard subsystem conventions for standalone
bindings.

> +
> +examples:
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232752.3136129-1-robh@kernel.org?part=1

  reply	other threads:[~2026-09-21 23:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 23:27 [PATCH] dt-bindings: iio: Add dedicated CM32181 schema Rob Herring (Arm)
2026-09-21 23:36 ` sashiko-bot [this message]
2026-09-22 15:01 ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921233609.C4DDC1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox