From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: robh@kernel.org, lee@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH] dt-bindings: mfd: Add MT6397 sound DAI cells
Date: Mon, 21 Sep 2026 23:36:45 +0000 [thread overview]
Message-ID: <20260921233645.7ECE11F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921232649.3132592-1-robh@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: mfd: missing conditional enforcement and example for #sound-dai-cells
--
commit 81069b8500a138169e7ffa4f54dfcaa00429702d
Author: Rob Herring (Arm) <robh@kernel.org>
dt-bindings: mfd: Add MT6397 sound DAI cells
This commit documents the sound DAI cell provided by MT6397 PMIC nodes.
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> index 3cbc0dc12c319..e2caa049a60ba 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> @@ -57,6 +57,9 @@ properties:
> "#interrupt-cells":
> const: 2
>
> + "#sound-dai-cells":
> + const: 1
> +
[Severity: Medium]
Does adding this at the top-level properties block bypass conditional
enforcement for specific variants?
By placing "#sound-dai-cells" at the top level without an allOf: if-then
conditional block restricted to "mediatek,mt6397", the schema fails to enforce
it as a required property for the MT6397 PMIC, and incorrectly allows it for
other PMIC variants.
Should it be added to the required list for MT6397 and included in the MT6397
example block, as per DT subsystem guidelines for new provider capabilities?
> rtc:
> type: object
> $ref: /schemas/rtc/rtc.yaml#
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232649.3132592-1-robh@kernel.org?part=1
next prev parent reply other threads:[~2026-09-21 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 23:26 [PATCH] dt-bindings: mfd: Add MT6397 sound DAI cells Rob Herring (Arm)
2026-09-21 23:36 ` sashiko-bot [this message]
2026-09-23 16:02 ` Rob Herring
2026-09-22 11:44 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921233645.7ECE11F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox