From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE32F4F7CC4 for ; Mon, 21 Sep 2026 18:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790016858; cv=none; b=nTekc9S8CHWZVmP/k2U8fzD+2Vychaz+RGk6ewK5wm/ib0e+Ed5QU5uIpKyT2MrmA0H9c1p4N7CiMjJwaOyR0GBGwCeBlmAkfBRC3JDKxbKumu4CniwC0E9lo006q5NQL7HMb8mVyzKt16JvRsw9p82oP5tpatyRJ2sLjvcmGkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790016858; c=relaxed/simple; bh=3zPDkuCDmQ38oUL9/eF9wJT7+qJydWJzTsR5SSVPT00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AbbhS+HtSi3J/of023mfbH1w2ks2YHSSUKxl0w2YPJozWOk/DtIYa5OnzptSNUfpEl7DDJdzOrf/UZwrrmEczKR6mGgx4+O2vCM34Rf/rNtzsuRAx23Lz6Xkfqi8aANw8/ZR5gQTvRdUIN2r9OrJiP2fBFdecB1eboGMZt+xhK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=msN5azof; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d888pvTU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="msN5azof"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d888pvTU" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68LFAJET1817144 for ; Mon, 21 Sep 2026 18:54:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oDQV9EtK+HUfHaV7DcliO9oX+WewlHGg2nJCScj03wk=; b=msN5azofTke6h336 QEV+s3kXcsG5zyUzCo6sIk+77SDV80V2Z24aMOoFwVI87c/y6QJGSYK90Ie1kuqV J1wJnF2CirCMX48kME/JKkjzSOAyGTu0MMa46gdtSZpfJFYxlYfmgDonHtgkbvP4 9YqRbuLS0El/3c8AW9NN1RTBWR3ICcbwsD72e+XJ3orAqg+f4+miLcnMeN0HDGuC C0fUzizQybk7dA/B6CKJkwPqF3CIkydM2kBZoUH/a3UUg+sCKRanDzVHUXO/dc9Q oVyIQd544EraUHvNUd6LJATnskxy8A1cQk33OxyJB7ZD8DNlFRRKTEBfWn6EDCGy +9PT2g== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gu011avqa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 18:54:15 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38ecc48b3c2so8089032a91.1 for ; Mon, 21 Sep 2026 11:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790016854; x=1790621654; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oDQV9EtK+HUfHaV7DcliO9oX+WewlHGg2nJCScj03wk=; b=d888pvTUDs6PjuSoybfrxkGa5V4gABlsrnOzs3kcmQWXVLri06aXkb9nsnW7j7qKDL 08rCbrXQC6RMz7+PJdyeE6cLQ0erakJsXqRt2k/HH89oaB0AfXYVqSnNlWCHvQNqgDD5 MF8NIq5OHA1LEjim99T12JrHmbX4NdfVb5vnJsejN12sT/pZPOz8TCuTBOGTCkDbIEAK dAOUNj4Hs9NDihj9WjIsLtV94SKqWwwSl3Jelbl6eIr+vcbSBGgAH5fJbHihsdrVPRNO QeDmxvG00kPu3Q+RU+7Pzv7vjzjQHhYFE+RGiBLuhTlX4SLSGXY9MjQmjS2yYtSfg9TU pDIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790016854; x=1790621654; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oDQV9EtK+HUfHaV7DcliO9oX+WewlHGg2nJCScj03wk=; b=Rh5rsoGQGt2WfrhKZHz6sjb7T4gNJPTlVTcp8xUYRCaEtvGlXG1pBlKBWS7egf/Yt4 wfPxZemUb7IUTldCLGmR4Zp8/DRHtTezYa5ofo+XApPEpqk3pMiTzJr7+ZVCkNYibyjp KVWf2/UGZAXrf7m4oO7lUkfMn3SdpBNOkbLMVJL0lGg3kONDoPnBRJ3nYVArfK4aSXW2 zY0wWQ+hAHAZ4v/XnOal04hNjtfjl1nf2ninRocuKZRnbRQoP4CLwyiqB8y47hh+8yqR BasUpYPTQu3yJEthCWQa7p4ObXBRgx19b7HDACwQXOM8YSr3z+1BdbQo3SgoAO5dfEtI lEag== X-Forwarded-Encrypted: i=1; AKwUvByZYYUbgSyyRcmwoRtwG31IT4VxyF+keBqa43EGeHUqv1JHx22qVVtgNhGGKiytQeMJVpbFzjc9/nym@vger.kernel.org X-Gm-Message-State: AFuF++m+wvkx1ckLof3/SqHfclqxyxD4vVwiQdl+HRTaM0zsaFimBE2W dBQydjlB7Gb6HF3/L14+TWMCA7DrIdy8EbCJklTGDdEYQxWFxqhC9lWlcT4Pk3Gdj/5T86PpZDf HXN2eqYpspHYZh4iFx8h3r1ufMT9JqB+3tMbvzeNJKSsiulnzIw7efWcN+DHdfYUA X-Gm-Gg: AYBFou3szXuhj1MBqMzt0fIpzkVx8E+HNwqbY2t9kBzmT4ea4Alb9QUvXuto0XBLvVy 48xX8oUAgCszM1BVu8ab93ADhxj02azZKeLdYyX35PJOojZJnxzgM4HtBEbZHj+zlqN2/HHWuDJ 5RKULDZXJhJlQa6Hhzou8fRrEGhmK7QunomEP1kZvOlKxPMN8nDIuvi+Oibr8MzryfTX4PXJN1R 0R525mMGBK1IwL2D3WIk3iGYyBqrcN6qGSrndc0JX+oj4LwwlWY75IztpvrIIoirAQ20wcXJTVq SWJ/sPPkr6/ujF60wxrVWeFRuZr+yGadTN008LZ2VC7LfN57bTkdZKdd8c+BAfLRDjI4RDMjhZ7 lUipQlKJx6RKtWEN1HKcqmrOXu/Q= X-Received: by 2002:a17:90b:288e:b0:3a0:2ffd:1a51 with SMTP id 98e67ed59e1d1-3a02ffd1c66mr7699750a91.10.1790016853967; Mon, 21 Sep 2026 11:54:13 -0700 (PDT) X-Received: by 2002:a17:90b:288e:b0:3a0:2ffd:1a51 with SMTP id 98e67ed59e1d1-3a02ffd1c66mr7699722a91.10.1790016853470; Mon, 21 Sep 2026 11:54:13 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33c331433besm33696755eec.16.2026.09.21.11.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 11:54:13 -0700 (PDT) From: Ajay Kumar Nandam Date: Tue, 22 Sep 2026 00:23:45 +0530 Subject: [PATCH v4 1/4] ASoC: qcom: q6apm: clear g_apm on driver removal Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260922-vmid-v4-v4-1-5fe21b1365a1@oss.qualcomm.com> References: <20260922-vmid-v4-v4-0-5fe21b1365a1@oss.qualcomm.com> In-Reply-To: <20260922-vmid-v4-v4-0-5fe21b1365a1@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ajay.nandam@oss.qualcomm.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.15.0 X-Proofpoint-GUID: WoPMmSKRN5ovYIW-ptT66Pvyty2EEi34 X-Authority-Analysis: v=2.4 cv=dPczC+Zb c=1 sm=1 tr=0 ts=6ab17d57 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=i9zpEd1wrD5FINdKp7YA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDI3NiBTYWx0ZWRfX52kZkYlSHuR4 fDa1rEwlRkbIrihMoJ31Feh6mOK1LGYRjhOASb1g2TEkQXmqgYdxy+eIWtzA1HJa2YW/aO/eZF5 feLaVwgXS4LvTBKzM+cCCrBiXPyBzt/pRvMrnV1vS5IyjV2/zqtQSo7g/5wEXJ3I0EycK4756mi J1LjGPVlbt3WL37rKsdrmERyKf4YPNZ6qK54FJcYA8oPRK6/tcE3KEHmq4oXmcuStDQckEb3o2S RcG0K6onakPM4zLVEPEGg9+P/5cFjsBgRD+9u02gPEczTkX9EA+Wn0ebiykYQLlAjxUmFQtOK/J kAHYmgY7ax8RV5w43zlpXYwm6NOAPaMoOJPePMs0AYRH2RG4nnsx4J93ZrU5VzCceAtRlauZEnu 8HIoFwhsXr+sYwTIm8xcJ+pwvdxoGmnKJxpRUnSE+VugStLV5Cu1H06IQqqPvFqZpJfajpIaphs t81zmYqjqItlwv0jnFA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDI3NiBTYWx0ZWRfX3wyPk/19IWcJ lKu9RkRVKZKFBMtsSwstAIcR314tFoNWIXN/LdGUXcBRVRN5HDvmKzyHU8dHkEEdPRLsYuoxVku ZxvyqwcFwUy1VlJpLJ+/GsFWQU9nBHE= X-Proofpoint-ORIG-GUID: WoPMmSKRN5ovYIW-ptT66Pvyty2EEi34 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_05,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210276 The global g_apm pointer is set during apm_probe() but never cleared in apm_remove(). After the driver is removed the devm-managed struct q6apm is freed, leaving g_apm dangling. A subsequent call to q6apm_is_adsp_ready() dereferences the freed pointer. Clear g_apm in apm_remove() before the component is unregistered so that q6apm_is_adsp_ready() returns false instead of triggering a use-after-free. Fixes: 5477518b8a0e ("ASoC: qdsp6: audioreach: add q6apm support") Signed-off-by: Ajay Kumar Nandam --- sound/soc/qcom/qdsp6/q6apm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 641d6d243229..12c6dfe4c58e 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -894,6 +894,7 @@ static int apm_probe(gpr_device_t *gdev) static void apm_remove(gpr_device_t *gdev) { + g_apm = NULL; of_platform_depopulate(&gdev->dev); snd_soc_unregister_component(&gdev->dev); } -- 2.34.1