Re: [PATCH 1/7] dt-bindings: mailbox: add Allwinner sun55i msgbox schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: mailbox: missing interrupt-names for optional multi-port interrupts
--

commit 10a4254c3034665a213647db7d6bda7467878d9f
Author: Tim Michals <tcmichals@gmail.com>

dt-bindings: mailbox: add Allwinner sun55i msgbox schema

Add Device Tree binding schema for the Allwinner 4-port hardware
Message Box controller found on sun55i (A523, A527, T527) and
sun60i (A733) SoCs.

> diff --git a/Documentation/devicetree/bindings/mailbox/allwinner,sun55i-a523-msgbox.yaml b/Documentation/devicetree/bindings/mailbox/allwinner,sun55i-a523-msgbox.yaml
> new file mode 100644
> index 0000000000000..4b73543c7902f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/allwinner,sun55i-a523-msgbox.yaml
[ ... ]
> +  interrupts:
> +    minItems: 1
> +    maxItems: 4
> +    description: |
> +      One interrupt per processor port. The host port interrupt is required;
> +      remote port interrupts are optional.

[Severity: Medium]
This block defines a variable-length list of interrupts, but lacks an
interrupt-names definition or a strict items array constraint.

If a board designer attempts to specify a partial list of interrupts (for
instance, providing the ARM and RISC-V interrupts, but skipping the DSP),
is there a way for the hardware configuration to retain the correct index
context without an interrupt-names list?

Without explicit descriptions or names per index, does this establish a
permanently ambiguous ABI for boards that do not connect all 4 interrupt
lines?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922034711.190253-1-tcmichals@gmail.com?part=1