From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDB8A522684 for ; Tue, 22 Sep 2026 08:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790064115; cv=none; b=QCRIpS2ZHMkQPHYbygdYpZcD3i+6smqUzc36Q9lhE/VVBZUH9Nrk6dmoG0zi2jRj42PYQr25ql8n1sxjx3zdaN5BU53RHsI5VInRDWxns3ThDnug94dXibCq2WiuLO1bNy06T3wczSsdsgfB175riAEz7r7EjXqrgnj/Urt6cbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790064115; c=relaxed/simple; bh=2W7J4uciibwZjfedWf0nIKQ9arloV2QAqcu52OEo04Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sp9Y89n6Eg+PA/TC3TIMhaTq4aVYz/2zum9SarCDTyt85QHTp1Y+B3T9MhHvdwE05SILoKO0g62SdZ9pMy54iEVLfEWJYSNJmvLl8qWkdli7YHec+Qmc37Vsmk4hnvmZg8oe8FssKVmFdqBxiTSXClXoQGzpejuEszr/y3hUiSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mQL9e2fF; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQL9e2fF" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b93204449so2951495e9.3 for ; Tue, 22 Sep 2026 01:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790064099; x=1790668899; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cUwmXn/jLJ9RJT7pjA9WmiefPpGzIu17sEQJkrs8eXE=; b=mQL9e2fFJlcQaP2tWvPb5kX3i+wpKhtOghrA46WaLa6ivFGLYNN++cw/uNYWHvMBaB BHDMyhMWJS33O0Dh81XRhtzn1njUWH+lb1S8pftaQ8lPnvR8zAAu29VNIHadYI61lbh1 Upgu859BD2nQuRnzcwP6cXJDxz8b1OhIhYCi/SbTij9O/zLL2Hs81uTt6+SMnWnRR5C/ kG/SRoHBVkk5Br/KWuasLGfIV9xckgFFkc3TSm8gVFGtck8Maq+G0hGBdTXOR/CEp03p mKZ3iMqXx1bt7RZ/pTrycxWcQO+7IhKm7KXx3gYIxzMtk+qpDk0xPvHSqRF5ykQEbT32 qtcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790064099; x=1790668899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cUwmXn/jLJ9RJT7pjA9WmiefPpGzIu17sEQJkrs8eXE=; b=B5o/TyfQzq1phynMyhJPI47rj1z5xCfL6YklQXt15a0uBaGgCE4IUjKHdlAEasJvVX iIppiqs1LipUcnYOCj1kF1eotwGqEi50Pd+0GSj+lzPwAttb3T2FUBa9IADcGE2t9DHo tuAZrNoY7PyJw//7JJFWq4Wdhqqmhwtlf2xDHX1WRnGixZRVwFNX308gYgzWwtIiPiHu 6iJi5dKbHlQJkM73o1MGHO+wlv+EMWZA+qUGTA0OO9Wq/LEfsAaEOmBIFZrrUucRsAs4 sEbk2Cbz1TLIEh1kbQa3MgeHWimL9a3wvfFXZc5ZPQagrV6sAgI7o9B2Ouf6tKbExlR2 LEKg== X-Forwarded-Encrypted: i=1; AKwUvByu7yNUzY8e2aX3YZwbBOuff6wt0LGXwVQJXuyk73FElA7Bi5n7JJtRvODRKUQTW49vVL1f53hmKieV@vger.kernel.org X-Gm-Message-State: AFuF++mX42MibvtohrIgvZLKzFta7TzIPowiCyM0RhQF6kL1jg99NBiA 3XBHdIO9U6Z5WdpJAJxyG23etBTPAcznEVTWDCuMKKy5oHQejcf/z/cO X-Gm-Gg: AYBFou1xwe0hqqIRCnbqh76XaOb833Zv+IrOOLbpg/hg3NJUqKBlTuGbUG0STBLhlgi tGQWm0OWhEQyXOYaITBFoJu7oSurgoYtQkF7GDy1G6IR/LBa2b1wcAHsu0yWZR2j/OXteD/NNGl mmqkBA+41STcf4+HmLIhgeSN4nTDsfCr85bhtdKkCVeUC5LQ5Kpqwp/oJm5DYmKDrrjfqyFmyzl m5WqyJfc8OpHbKTqLSaQKbI7pLPrddcCghEfAJmx1TZDfaGCL3cvlEUIUcbtoEvHDy4JEe5JWH5 VodZWpPi/8rTT95YTLQOdPeKwTI0Cxl1iw8HpjatwlFsKrwGxyZpERTaHf90ZaPsO0v5TFeMmMZ umZ516b4H6Sr+GMqKGbGYsf+xOXbfmyBZtOES5GyUwj0gd+mMY1NbTLs26gcvjJJsLzykMQ6B+b 6aRis6vrbZc5O/x2IrZrMKmi7Wijdz3193Ns616gi79HfIf9n5VPcGEL3TxXJw8xZz0S6AgFz/B V7WxkppO3yJHHVIy0WMaaIBrYRnxjIl7lHEwVwZNMUUJIpQPwGom1juexFaYxFTG1qwGzNY9oHJ vLY= X-Received: by 2002:a05:600c:a00a:b0:499:d95a:41f with SMTP id 5b1f17b1804b1-49fc7b83237mr163730805e9.0.1790064099450; Tue, 22 Sep 2026 01:01:39 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B80530056971C6280202175.dsl.pool.telekom.hu. [2001:4c4e:1b80:5300:5697:1c62:8020:2175]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fdaaf97e2sm18248625e9.2.2026.09.22.01.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 01:01:39 -0700 (PDT) From: Igor Paunovic To: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Hugo , Robert Foss , Sidong Yang , Diederik de Haas , Sebastian Reichel , Jiaxing Hu , Nicolas Dufresne , Jonas Karlman , Guangshuo Li , =?UTF-8?q?H=C3=BCseyin=20BIYIK?= , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Paunovic Subject: [PATCH v2 10/11] accel/rocket: register a devfreq cooling device Date: Tue, 22 Sep 2026 10:01:13 +0200 Message-ID: <20260922080114.44662-11-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260922080114.44662-1-royalnet026@gmail.com> References: <20260922080114.44662-1-royalnet026@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With devfreq driving the NPU clock, a thermal zone can now throttle the NPU by capping that clock. Register the cooling device so a devicetree can bind it to a zone. The _em variant is used, not because there is an energy model today but so that there will be one the day a power coefficient for this NPU is measured. There is none now: the NPU core nodes carry no dynamic-power-coefficient, Rockchip does not publish one, and a made-up number would be worse than no number. devfreq_cooling_em_register() logs the missing model at debug level and registers the cooling device anyway, so what this gets today is step-wise throttling with no power model for the IPA governor to use. Measuring the coefficient is follow-up work. Registration is allowed to fail. A kernel built without DEVFREQ_THERMAL gets a stub that returns an error, and losing throttling is not a reason to refuse to drive the NPU at all, so the failure is logged and probe carries on. The cooling device is unregistered by hand before the devfreq device it is attached to goes away. Assisted-by: LLM sparse checkpatch Signed-off-by: Igor Paunovic --- v2: wording only, for the shared table. drivers/accel/rocket/rocket_devfreq.c | 25 +++++++++++++++++++++++++ drivers/accel/rocket/rocket_devfreq.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/drivers/accel/rocket/rocket_devfreq.c b/drivers/accel/rocket/rocket_devfreq.c index 871fa370eb432..c81887734de77 100644 --- a/drivers/accel/rocket/rocket_devfreq.c +++ b/drivers/accel/rocket/rocket_devfreq.c @@ -3,6 +3,7 @@ #include #include +#include #include #include #include @@ -446,6 +447,25 @@ int rocket_devfreq_init(struct rocket_device *rdev) goto err_remove_table; } + /* + * Thermal throttling is optional, so a kernel built without + * DEVFREQ_THERMAL keeps a working NPU rather than a failed probe. + * + * The _em variant is used so that the driver is ready for an energy + * model the day a power coefficient for this NPU is measured. There is + * none today: the NPU core nodes have no dynamic-power-coefficient, + * the vendor does not publish one, and inventing a number would be + * worse than having none. Without it the EM registration inside is + * skipped and throttling is step-wise, with no power model for IPA to + * use. + */ + rdevfreq->cooling = devfreq_cooling_em_register(rdevfreq->devfreq, NULL); + if (IS_ERR(rdevfreq->cooling)) { + dev_info(dev, "no devfreq cooling device (%pe), NPU will not be throttled\n", + rdevfreq->cooling); + rdevfreq->cooling = NULL; + } + return 0; err_remove_table: @@ -468,6 +488,11 @@ void rocket_devfreq_fini(struct rocket_device *rdev) dev = rdevfreq->owner->dev; + if (rdevfreq->cooling) { + devfreq_cooling_unregister(rdevfreq->cooling); + rdevfreq->cooling = NULL; + } + devfreq_remove_device(rdevfreq->devfreq); rdevfreq->devfreq = NULL; diff --git a/drivers/accel/rocket/rocket_devfreq.h b/drivers/accel/rocket/rocket_devfreq.h index 65a9de6d37389..26a3749078b9f 100644 --- a/drivers/accel/rocket/rocket_devfreq.h +++ b/drivers/accel/rocket/rocket_devfreq.h @@ -10,9 +10,11 @@ struct rocket_core; struct rocket_device; +struct thermal_cooling_device; struct rocket_devfreq { struct devfreq *devfreq; + struct thermal_cooling_device *cooling; struct devfreq_simple_ondemand_data gov_data; /* -- 2.43.0