Re: [PATCH v7 2/3] dt-bindings: net: can: holt,hi311x: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing spi-peripheral-props.yaml reference rejects valid SPI properties
--

commit daeb2992a77029d59549250b99f2dd7fac156a7f
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: net: can: holt,hi311x: Convert to DT schema

This commit converts the Holt HI-311X stand-alone CAN controller bindings
from free-form text to DT schema format. It establishes the base properties
using can-controller.yaml and strictly enforces them.

> diff --git a/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
> new file mode 100644
> index 0000000000000..d9e3584590c65
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
[ ... ]
> +allOf:
> +  - $ref: can-controller.yaml#

[Severity: Medium]
Since this device sits on an SPI bus, doesn't it need a reference to
/schemas/spi/spi-peripheral-props.yaml# here to support standard SPI
properties?

The v7 changelog mentions dropping this reference because the example doesn't
use SPI properties. However, real-world device trees that instantiate this
SPI device will routinely provide standard SPI properties, such as
spi-max-frequency.

[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - interrupts
> +
> +unevaluatedProperties: false

[Severity: Medium]
Because unevaluatedProperties is set to false here, the missing reference to
spi-peripheral-props.yaml means any standard SPI bus configuration properties
will be treated as invalid by the schema tools.

Will this cause dtbs_check to reject valid device tree nodes that include
necessary SPI properties?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922084542.104788-1-quchaosheng000406@163.com?part=2