Re: [PATCH v4 4/8] ASoC: qcom: lpass-va-macro: Add shikra compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ASoC: lpass-va-macro: static version assignment bypasses hardware cross-check
--

commit 56f2a447aaf7dc3ac69e03680c277ea0d7300890
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

ASoC: qcom: lpass-va-macro: Add shikra compatible

This commit adds shikra specific VA macro data and register programming
needed by the LPASS codec v4.1 implementation. It extends the VA macro
with four adaptive filter blocks and adds the new registers as a separate
reg_default array.

> diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c
> index 03d6434a4a126..02dc3346924f1 100644
> --- a/sound/soc/codecs/lpass-va-macro.c
> +++ b/sound/soc/codecs/lpass-va-macro.c
[ ... ]
> @@ -463,6 +674,27 @@ static const struct regmap_config va_regmap_config = {
[ ... ]
> +static const struct regmap_config va_4_1_regmap_config = {
> +	.name = "va_macro",
> +	.reg_bits = 32,
> +	.val_bits = 32,
> +	.reg_stride = 4,
> +	.cache_type = REGCACHE_MAPLE,
> +	.reg_defaults = va_4_1_defaults,
> +	.num_reg_defaults = ARRAY_SIZE(va_4_1_defaults),
> +	.max_register = VA_4_1_MAX_OFFSET,
> +	.volatile_reg = va_is_volatile_register,
> +	.readable_reg = va_is_readable_register,
> +	.writeable_reg = va_is_rw_register,
> +};
> +
> +static const struct va_macro_data shikra_va_data = {
> +	.has_swr_master = true,
> +	.has_npl_clk = true,
> +	.version = LPASS_CODEC_VERSION_4_1,

[Severity: Medium]
Does this static version assignment bypass the hardware cross-check?

The commit message states that probe cross-checks the register layout against
the version reported by the hardware. However, setting the version here causes
the probe function to skip reading the hardware register entirely:

sound/soc/codecs/lpass-va-macro.c:va_macro_probe() {
	...
	if (data->version) {
		lpass_macro_set_codec_version(data->version);
	} else {
		/* read version from register */
		ret = va_macro_set_lpass_codec_version(va);
		if (ret)
			goto err_rpm_put;
	}
	...
}

Because data->version evaluates to true for the shikra compatible,
va_macro_set_lpass_codec_version() is bypassed. If a mismatched device tree
is booted on older hardware that is not v4.1, could this lead to bus errors
by accessing unsupported ADPT registers?

> +	.regmap_config = &va_4_1_regmap_config,
> +};
> +
>  static int va_clk_rsc_fs_gen_request(struct va_macro *va, bool enable)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-add_shikra_support-v1-0-6c6cb6444caf@oss.qualcomm.com?part=4