Re: [PATCH 1/4] arm64: dts: qcom: hamoa: Add CoreSight nodes for APSS debug block

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt: empty port@2 in funnel@12080000 violates OF graph rules
--

commit 48f77584a29ad03f77385cb8599896371e32bbd1
Author: Jie Gan <jie.gan@oss.qualcomm.com>

arm64: dts: qcom: hamoa: Add CoreSight nodes for APSS debug block

The APSS debug block is built with CoreSight devices like ETM,
replicator, funnel and TMC ETF. This patch adds device tree nodes for
these devices to enable ETM trace, tying their power states to the CPU
cluster domains.

> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> index 4e35254cdd11a..370b6bba2594f 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi

[ ... ]

> @@ -8433,6 +8645,678 @@ ddr_funnel1_out: endpoint {
>  			};
>  		};
>  
> +		funnel@12080000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x0 0x12080000 0x0 0x1000>;

[ ... ]

> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;

[ ... ]

> +				port@2 {
> +					reg = <2>;
> +
> +					apss_funnel_in2: endpoint {
> +						remote-endpoint = <&ncc2_etf_out>;
> +					};
> +				};
> +			};

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/purwa.dtsi b/arch/arm64/boot/dts/qcom/purwa.dtsi
> index 4348dd3d1dc59..90069c8e1d400 100644
> --- a/arch/arm64/boot/dts/qcom/purwa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/purwa.dtsi
> @@ -8,7 +8,15 @@
>  
>  #include <dt-bindings/clock/qcom,x1p42100-videocc.h>
>  
> +/delete-node/ &apss_funnel_in2;

[Severity: Low]
Does this deletion violate the OF graph bindings? By deleting the
apss_funnel_in2 endpoint node here, its parent node port@2 in funnel@12080000
(defined in hamoa.dtsi) is left as an empty shell containing only reg = <2>.

OF graph rules require port nodes to have at least one endpoint child. Leaving
an empty port triggers a dtc compilation warning (graph port node has no
endpoint children) during make dtbs_check.

Could we assign a label directly to port@2 in hamoa.dtsi so that the entire
port node can be deleted here in purwa.dtsi instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-add-etm-devices-for-multiple-qcom-platforms-v1-0-c2a8c3225a2e@oss.qualcomm.com?part=1