From: sashiko-bot@kernel.org
To: "Roman Vivchar" <rva333@protonmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: usb: mtu3: add mt6595
Date: Tue, 22 Sep 2026 10:44:56 +0000 [thread overview]
Message-ID: <20260922104456.EAF4F1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260922-6595-mtu3-v2-1-71203a362b36@protonmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: usb: mtu3: missing companion xhci compatible for mt6595
--
commit 69c32994e4cd3df8ae84107c2e4552ba6293f82d
Author: Roman Vivchar <rva333@protonmail.com>
dt-bindings: usb: mtu3: add mt6595
Add a compatible string for the MTU3 IP found on the MediaTek mt6595 SoC.
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index 21fc6bbe954f9..4538df164a16d 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -22,6 +22,7 @@ properties:
> items:
> - enum:
> - mediatek,mt2712-mtu3
> + - mediatek,mt6595-mtu3
[Severity: Low]
Does the addition of this compatible string trigger a validation failure
during dtbs_check for mt6595 boards utilizing host or OTG modes?
The mediatek,mtu3.yaml schema enforces that any xHCI child node must comply
with the companion schema:
Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml:
"^usb@[0-9a-f]+$":
type: object
$ref: /schemas/usb/mediatek,mtk-xhci.yaml#
When a device tree for mt6595 configures the MTU3 controller in host or
dual-role mode, it requires a child xHCI node with the mediatek,mt6595-xhci
compatible string.
However, this companion schema is omitted from the patch and does not list
the new compatible string:
Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml:
compatible:
items:
- enum:
- mediatek,mt2701-xhci
- mediatek,mt2712-xhci
Should mediatek,mtk-xhci.yaml be updated to include mediatek,mt6595-xhci to
support the mandatory xHCI child node?
> - mediatek,mt8173-mtu3
> - mediatek,mt8183-mtu3
> - mediatek,mt8186-mtu3
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-6595-mtu3-v2-0-71203a362b36@protonmail.com?part=1
next prev parent reply other threads:[~2026-09-22 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 10:36 [PATCH v2 0/3] usb: mtu3: add mt6595 support Roman Vivchar via B4 Relay
2026-09-22 10:36 ` [PATCH v2 1/3] dt-bindings: usb: mtu3: add mt6595 Roman Vivchar via B4 Relay
2026-09-22 10:44 ` sashiko-bot [this message]
2026-09-28 7:51 ` Krzysztof Kozlowski
2026-09-22 10:36 ` [PATCH v2 2/3] usb: mtu3: add SoC platform data for FIFO quirk handling Roman Vivchar via B4 Relay
2026-09-22 11:46 ` AngeloGioacchino Del Regno
2026-09-22 10:36 ` [PATCH v2 3/3] usb: mtu3: add mt6595 support Roman Vivchar via B4 Relay
2026-09-22 10:50 ` sashiko-bot
2026-09-22 11:46 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922104456.EAF4F1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rva333@protonmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox