Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add initial Valve Deckard devicetree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: incorrect regulator supply names for vishay,vcnl4040
--

commit 04ec091c4806a5aef627fbe5d3809fe2eef39d6e
Author: Neil Armstrong <neil.armstrong@linaro.org>
arm64: dts: qcom: sm8650: Add initial Valve Deckard devicetree

This commit adds the initial devicetree for the Valve "Steam Frame" (codename
Deckard), a VR headset based on the Snapdragon 8 Gen 3 SoC. It includes
definitions for reserved memory, regulators, GPIOs, UFS storage, USB,
Wi-Fi/Bluetooth, and I2C peripherals.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
> new file mode 100644
> index 0000000000000..cd801359d2b57
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts

[ ... ]

> +	light-sensor@60 {
> +		compatible = "vishay,vcnl4040";
> +		reg = <0x60>;
> +
> +		vin0-supply = <&vreg_l2b_3p0>;
> +		vin1-supply = <&vreg_l15b_1p8>;

[Severity: Medium]
Will the vcnl4000 driver be able to properly find and enable these regulators?

The driver expects the regulators to be named vdd, vio, and vled, but here
they are provided as vin0-supply and vin1-supply. Because they are not bound
to the names the driver expects, they might remain off or get disabled by a
late initcall, potentially causing the sensor to fail probing or I2C
communication.

> +
> +		proximity-near-level = <220>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-topic-sm8650-deckard-initial-dt-v1-0-c25e7759d04a@linaro.org?part=2