Re: [PATCH v4 2/3] platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] hwmon: subsystem layering violation by registering hwmon device from platform driver
--

commit fad2a849321ec9af59f9a8420c3cb98f8ed6865e
Author: Oleg Keri <okerixx@gmail.com>

platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver

This commit adds an Embedded Controller (EC) driver for the Lenovo Yoga Slim
7x Gen 11 laptop on the Snapdragon X2 Elite platform. It provides access to
thermistors, battery cell voltages, CPU fan speed, and keyboard backlight
control over I2C.

> diff --git a/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c b/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c
> new file mode 100644
> index 0000000000000..a16849877dd7b
> --- /dev/null
> +++ b/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c
[ ... ]
> +	if (!ec->temp_present) {
> +		return dev_err_probe(dev, -ENODEV,
> +				     "no thermistor reported a usable value\n");
> +	}
> +
> +	dev_dbg(dev, "thermistors present: %#lx\n", ec->temp_present);
> +
> +	hwmon = devm_hwmon_device_register_with_info(dev, "yoga_slim7x_ec", ec,
> +						     &slim7x11_ec_chip_info, NULL);

[Severity: Medium]
Does registering the hardware monitoring device directly from outside the
drivers/hwmon/ directory violate the subsystem guidelines? 

The HWMON guide dictates that hardware monitoring functionality in
multi-function devices should be implemented as an auxiliary device driver
residing in drivers/hwmon/, and that registering from outside this
directory bypasses maintainer review.

> +	if (IS_ERR(hwmon))
> +		return PTR_ERR(hwmon);
> +
> +	ec->kbd_led.name = "platform::kbd_backlight";
> +	ec->kbd_led.max_brightness = SLIM7X11_EC_KBLT_MAX;
> +	ec->kbd_led.brightness_get = slim7x11_ec_kbd_led_get;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922165737.260443-1-okerixx@gmail.com?part=2