Re: [PATCH] arm64: dts: qcom: x1e78100-thinkpad-t14s: Add thermal zones for PMICs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: missing #thermal-sensor-cells on pmk8550_vadc breaks thermal zones
--

commit 2a17ffae5a77fa31a5cd42aff532d2ad2eb0c1c2
Author: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>

arm64: dts: qcom: x1e78100-thinkpad-t14s: Add thermal zones for PMICs

This commit adds thermal zones for the ThinkPad T14s and describes the
board temperature sensors exposed through the PMK8550 VADC. It includes
passive and shutdown thermal zones for the keyboard area and back cover,
along with monitoring-only zones.

> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> index 5cc6a63d1ef66..9407868864ad3 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> @@ -10,6 +10,117 @@ / {
>  	compatible = "lenovo,thinkpad-t14s-lcd", "lenovo,thinkpad-t14s",
>  		     "qcom,x1e78100", "qcom,x1e80100";
>  
> +	thermal-zones {
> +		soc-thermal {
> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_GPIO_100K_PU(1)>;
> +		};
> +
> +		keyboard-thermal {
> +			critical-action = "shutdown";
> +			polling-delay-passive = <500>;
> +
> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX2_GPIO_100K_PU(1)>;

[Severity: High]
Will this thermal zone fail to parse and register at runtime due to the target
pmk8550_vadc node missing the #thermal-sensor-cells property?

Without these thermal zones registering successfully, the system might lack
the intended thermal throttling for the keyboard constraint and the 73°C
shutdown trip, risking hardware overheating under load.

[ ... ]
> @@ -58,3 +170,33 @@ edp_bl_pwm: edp-bl-pwm-state {
>  &pmk8550_pwm {
>  	status = "okay";
>  };
> +
> +&pmk8550_vadc {
> +	channel@144 {
> +		qcom,adc-tm;
> +	};

[Severity: High]
Should this extension of pmk8550_vadc include #thermal-sensor-cells = <1>; ?

Since the base definition in hamoa-pmics.dtsi omits it, it appears to be
required here for the framework to parse it as a valid thermal sensor provider.
Otherwise, of_parse_phandle_with_args() returns -EINVAL unconditionally at
boot when evaluating the thermal-sensors properties above.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922181818.5503-1-daniel.lezcano@oss.qualcomm.com?part=1