From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: Fix TAS2563 address constraints
Date: Tue, 22 Sep 2026 21:34:12 +0000 [thread overview]
Message-ID: <20260922213412.D6DC11F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922212122.1116270-1-robh@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: ti,tas2781: silent schema failure from scalar const on compatible
--
commit c73c1b75f173e00cf5a4898fb3f42699d6a9f494
Author: Rob Herring (Arm) <robh@kernel.org>
ASoC: dt-bindings: Fix TAS2563 address constraints
This commit modifies the conditional block for the TAS2781 device to apply
the register range only when the compatible string is exactly ti,tas2781.
This is intended to prevent the TAS2781 single-address rule from incorrectly
applying to TAS2563 nodes.
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> index aa5a317b5a361..50c7792b24f81 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -219,9 +219,7 @@ allOf:
> - if:
> properties:
> compatible:
> - contains:
> - enum:
> - - ti,tas2781
> + const: ti,tas2781
[Severity: Medium]
Will this scalar const constraint on the compatible property cause the schema
validation to silently fail?
Looking at the allOf.if.properties.compatible evaluation, the compatible
property is always parsed and evaluated as a string array (e.g.,
["ti,tas2781"]). Because JSON Schema const performs strict equality
validation, checking a string array against a scalar string will evaluate
to false for all nodes.
Consequently, it looks like the then block enforcing the reg constraints
will never be applied when checking device tree nodes. Should this use
contains: const: ti,tas2781 instead to correctly match elements within
the array?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922212122.1116270-1-robh@kernel.org?part=1
next prev parent reply other threads:[~2026-09-22 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 21:21 [PATCH] ASoC: dt-bindings: Fix TAS2563 address constraints Rob Herring (Arm)
2026-09-22 21:34 ` sashiko-bot [this message]
2026-09-23 10:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922213412.D6DC11F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox