From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E29A3BFAF7 for ; Wed, 23 Sep 2026 16:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790181250; cv=none; b=AjVZn1wgnh6a/WXCaRICMo+nTntxAaO7C5VZF3lsQkOKeWRxtUuB1oq4Gu6boEPhvt4MYN7ZkZtSAxNJWQMH3jiaTrrHRSw6Q0egTsY504dHEEx0QgDOHXFDgzMDEk3MigY+VZW63CVsP1o9H74nb+UD27SWocpslOPZLFsgl8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790181250; c=relaxed/simple; bh=coYj6sdykkd1PCi2KNjcYdAGy8fu1yFBf4PZfUBvnrY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CYpB3TaV9/pmNJstXIYmsIChPLFAa4K48EqfvwJemZ207A69qdNgFoU8GBslgjbkyhh8PBYDHYnRXHWilNWG7Dm8t8xHwI1o5mJ+zC0ykPAu3ved7YhZZ/j+OwZCyftcuiNzrIYQsFGWwfgAczo0kVrcUXlFcJWApo6Wv5/nvH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U2LWSuA9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jAZT0ooo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U2LWSuA9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jAZT0ooo" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NGTv0U064051 for ; Wed, 23 Sep 2026 16:34:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= llOjDMEuBFDv+DyQdi/V2z3mxuMuRRhWgPZ4yTvTgrw=; b=U2LWSuA9ySbC9DCv oxBX5bPcUF7vpwb+ebNWmeTDI/8DmP8rIYhSSyMr/L13/5kX3Zjq4feHf/XlD4pS /1LdmbKvfDr0LkK4zyy71hJLrSUx96gJm/qXABVc9UNw4U0nx0VnFcVHM3q6ygqR J31VkBwr2MRdO9/zJX/BcUWJuQF29nQN/jHrpc95HEYpQrR69IWH+RcxNYa1GmEC CASNA1IRQfAakvJrU/ff3iqHKAsQrZ7JDg2ZTeNfEMyfDf4aaBnV2FhfCi8V5DaO w2a1xoe6qOcbZRzp38FT+9h88POIqobtecGmuoEmWlHX3mc6Nnn9mNBR/iXBsz6J BMH/xA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvfkbguy1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 23 Sep 2026 16:34:03 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2d94f086fedso10549575ad.1 for ; Wed, 23 Sep 2026 09:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790181242; x=1790786042; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=llOjDMEuBFDv+DyQdi/V2z3mxuMuRRhWgPZ4yTvTgrw=; b=jAZT0oooBgcDa9O/kLR9M5vCeODvhRctJOpVOlBafLgzIEPIDQNKyXxEOGw8LDIYdg M+CDXj6YwUhK6pW06bD966TOH8pFO7xiTw1//YwQOul1Wm4xCvpBPBG69XUHXoSO1LuK QR49Jig36y6u8BUCVLc1MxvdDiUMBuK9N9PTwtTjiR/8GU/nxof7VVUg9Rq+rLqMqryA +hCXbjXU/9UAsFXKbN4RI5Al8At0b88yGNF21x/HBru4xBijm18nOajJnqdox7G6ddWq LH3JHC58un47Aj0DbLedE02/NKEJvODUH8rDAIgE1GJbEaCscKEPdmcxhlHBy18ZJlWy jh0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790181242; x=1790786042; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=llOjDMEuBFDv+DyQdi/V2z3mxuMuRRhWgPZ4yTvTgrw=; b=dehPS/NYGFMCZoaxdlmaJwsCCu5t08fP6Vd5RUXzWVNWIGBufudtjJChQ9LTwHtwNB 3jFqp6HQ/SwADfN+FjQ7rzW/PXg4DE+zsL9o0Z4KUOsSLw3yx8KTXx5oPvxngSstyTFe sp3s+NugU/F9iqIPzaxoZ50BTTo2lFfv6CSDonQobQ9+Q8AHyJJogH9ts5vV+BdQQChz MMovON58o3MUo0pxQDbXiNOUZ+QWLGNn1YNaQy5RV3IlLaGJY8ilxvIFvwNr8qxad+Z9 kg0iJKoiQi/aqQhYDYUwA4Nzc4Q4eqnD7fUqxpeFDy0yfCLS9+Ak7yDDY1eLQitfJD3H h2IA== X-Forwarded-Encrypted: i=1; AKwUvByeT52eB9sdtdzVAWrtxEG8hxtGl6LBh7F1LTfZ9Ilz0OYhxsLuRP8/isZyN3g8tr6OvApWflxnYAm/@vger.kernel.org X-Gm-Message-State: AFuF++lztBPVPUpz8shRSsGe/JvIKgRXQyMHhI5IAD3/7nyK5FP5hx9m MML7iWMSqbW8xAtrdFtYO79Wd5cYoVE+aGe+Fn1ItdI3ff1luGPYtRDyIZn+G8MzofmRJ91z0VF TsTuo1I6kc9f6qhjYead0T+ZgHCX1FRDJmcvjG7TOJPYe4/Pd1zJncZ05mmRTrqUe X-Gm-Gg: AYBFou3OgBk6bjtP501iurisDc1BchnmYlvMt+TQ8O4uewYHjYG2TqOqpHz+x0NKFAh yvgTUbtEY7nOfAtPqw4RRvOKw5ydgYfmFObF17dHnyO/E5YsJlgVVV/W/8mYqB3fOBL83eeTSNh ipKDJn48M5yasj9mDoMxzwoqwHsngkRcmMPHE8gkMifED6epc9PEslccbWl39s5MXMUkeFd5YPx 8tZObpenc0ea2jFmTdpmIvuIImDw6EBRlRr83J8lFzCHvpnb+lrLyJXznC9jf0r6E5qBxPs8oq1 ofaFJ8Dw5PQGycOIEbQsTLhb3txNNW/edMIBnQ9buR0eeDvz9Pp+XAP0SgO0JmiyG4/7UNG17sg z3fvUJscV/OxYP0GxH/pQG1I5vb8= X-Received: by 2002:a17:903:2f85:b0:2dd:c053:ec71 with SMTP id d9443c01a7336-2df69dc771dmr26576375ad.36.1790181241918; Wed, 23 Sep 2026 09:34:01 -0700 (PDT) X-Received: by 2002:a17:903:2f85:b0:2dd:c053:ec71 with SMTP id d9443c01a7336-2df69dc771dmr26575935ad.36.1790181241272; Wed, 23 Sep 2026 09:34:01 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df6a5a6d35sm13994895ad.19.2026.09.23.09.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 09:34:01 -0700 (PDT) From: Ajay Kumar Nandam Date: Wed, 23 Sep 2026 22:03:38 +0530 Subject: [PATCH v6 1/4] ASoC: qcom: q6apm: clear g_apm on driver removal Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260923-vmid-v4-v6-1-3d61a0319b1c@oss.qualcomm.com> References: <20260923-vmid-v4-v6-0-3d61a0319b1c@oss.qualcomm.com> In-Reply-To: <20260923-vmid-v4-v6-0-3d61a0319b1c@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ajay.nandam@oss.qualcomm.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.15.0 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA2NiBTYWx0ZWRfX8VPvS9wjIk/b XiGDQmBVAR47gDTcdbWyug5t1RCLKfvl5Xr3HxtI7pGO4gtDCHwWQUbmR7JUGXbpsSNDh89Z6Wl g1EZndOKUeyK1xTDYT7Q3pzBRWBT9vk= X-Proofpoint-GUID: 8__nZR1Mcql5PC397dzSvV9Q0aqqgttj X-Authority-Analysis: v=2.4 cv=RYMFmFtv c=1 sm=1 tr=0 ts=6ab3ff7b cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=i9zpEd1wrD5FINdKp7YA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA2NiBTYWx0ZWRfXxvr+nGGKFWDq rrGpKzrecY6RdpycqteVoyiWbmGJZQuBD5WM4z7SsYfx5wp5d/ynr/E2p6UD+uRygppfCl68vQn EoDrl88yN5gxejzNWl6gIJU7Srz4NLxSPil61/NMtvVDZk8WtcxWXwfkPSzS+wHI1N81MMJ5GNY paESFZfBMVtLGPAXtrOP5LjYKFkNrSXJESY1QalyxKwiPo/dhAnwRYjyKQUKfxzQgzrogkHHWWn YQpiO+3uY5PzcsOB+VlhfPE5hyQxpgdDbXOtkHDr9KiHIHXzHskLl/GYNK5K/MNgT2fv93EZZTA 40qiPacITu5vHcd294sFiynCSM6qKS3ZOLKeOZdOEADihZQy/MZXzpOX+hvm441l8I5AMWae2Z0 NxcZ4ovKYG4PjAdaI8SrV9K5Iep9zYY9+5pF24O7I6W92APOyuicd7I0ZbOpy/eAZ5lHDmt/474 QYsTX4Dwa/we+vZx0Mg== X-Proofpoint-ORIG-GUID: 8__nZR1Mcql5PC397dzSvV9Q0aqqgttj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230066 The global g_apm pointer is set during apm_probe() but never cleared in apm_remove(). After the driver is removed the devm-managed struct q6apm is freed, leaving g_apm dangling. A subsequent call to q6apm_is_adsp_ready() dereferences the freed pointer. Clear g_apm in apm_remove() before the component is unregistered so that q6apm_is_adsp_ready() returns false instead of triggering a use-after-free. Fixes: 5477518b8a0e ("ASoC: qdsp6: audioreach: add q6apm support") Signed-off-by: Ajay Kumar Nandam --- sound/soc/qcom/qdsp6/q6apm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index f167b9dae3fa..eef4b496d2aa 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -900,6 +900,7 @@ static int apm_probe(gpr_device_t *gdev) static void apm_remove(gpr_device_t *gdev) { + g_apm = NULL; of_platform_depopulate(&gdev->dev); snd_soc_unregister_component(&gdev->dev); } -- 2.34.1