Re: [PATCH v2] dt-bindings: mfd: convert rk805 pinctrl to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: mfd: missing gpio-controller in required and examples
- [Low] mfd: commit message description is not capitalized
--

commit e55b5757962f2de0568f1d27e4b5f113a8f4aaad
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: mfd: convert rk805 pinctrl to DT schema

This commit folds the RK805 pinmux text binding into the existing
rockchip,rk805.yaml MFD schema and adds the missing -pins$ child
node schema. It then removes the standalone text binding.

Link: https://sashiko.dev/#/patchset/20260923025302.374919-1-quchaosheng000406@163.com?part=1

> dt-bindings: mfd: convert rk805 pinctrl to DT schema

[Severity: Low]
The MFD subsystem guidelines require that the description after the subsystem
prefix be capitalized. Should the word convert be capitalized to Convert here
to align with the standard MFD naming conventions?

> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> index da2391530c16c..6353aef3ebe7c 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml

[ ... ]

> @@ -86,6 +86,34 @@ properties:
>          unevaluatedProperties: false
>      unevaluatedProperties: false
>  
> +patternProperties:
> +  '-pins$':
> +    type: object
> +    description:
> +      The RK805 has two output-only GPIOs which can be muxed to the GPIO
> +      function and driven low or high at boot.

[Severity: Medium]
Since the RK805 PMIC provides GPIO controller capabilities, the device tree
binding guidelines state that the corresponding properties (gpio-controller
and #gpio-cells) must be added to the global required list. 

The deleted text binding explicitly enforced this requirement. Should
gpio-controller and #gpio-cells be appended to the required list in this
schema to prevent incomplete device tree nodes from silently passing validation?

[ ... ]

> @@ -137,6 +165,12 @@ examples:
>              vcc5-supply = <&vcc_io>;
>              vcc6-supply = <&vcc_io>;
>  
> +            rk805_default: rk805-default-pins {
> +                pins = "gpio0", "gpio1";
> +                function = "gpio";
> +                output-high;
> +            };

[Severity: Medium]
Does the example PMIC node also need to be updated to include
gpio-controller; and #gpio-cells = <2>; to demonstrate a valid and complete
configuration?

Device tree binding guidelines mandate that the examples section must include
all required properties for hardware capabilities like GPIO controllers.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923034245.396417-1-quchaosheng000406@163.com?part=1