Re: [PATCH v3] dt-bindings: mfd: Convert rk805 pinctrl to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] dt-bindings: mfd: DT ABI breakage for rk805 pinctrl container node
- [Low] dt-bindings: mfd: missing driver prefix in commit message
--

commit fb35b4123e96d1c068df56e50d1eaaf6204d1a23
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: mfd: Convert rk805 pinctrl to DT schema

This commit converts the pinctrl binding for the Rockchip RK805 PMIC from a
standalone text file to a YAML schema integrated into rockchip,rk805.yaml. It
drops the standalone text binding and adds a child node schema for pin
configuration nodes.

Link: https://sashiko.dev/#/patchset/20260923034245.396417-1-quchaosheng000406@163.com?part=1

> dt-bindings: mfd: Convert rk805 pinctrl to DT schema

[Severity: Low]
Does this commit message subject violate the MFD subsystem naming conventions?

The guidelines strictly require the prefix format:
mfd: <Driver>: <Capitalized description>

The driver or binding name component (e.g., rk805: or rockchip,rk805:)
appears to be completely missing before the capitalized description.

> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> index da2391530c16c..681a90a265c06 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> @@ -86,6 +86,34 @@ properties:
>          unevaluatedProperties: false
>      unevaluatedProperties: false
>  
> +patternProperties:
> +  '-pins$':
> +    type: object

[Severity: High]
Does this pattern restrict child nodes to only those ending in -pins,
incorrectly rejecting the legacy pinmux container node?

Device tree bindings are considered kernel ABI, and schemas must validate
existing correct device trees. The original pinctrl-rk805.txt explicitly
documented a nested structure where a container node (named pinmux) held
sub-nodes (e.g., gpio01) containing the actual pin configuration.

With the new YAML schema setting additionalProperties: false at the top level
and restricting child nodes via patternProperties to only match the -pins$
regex, existing device trees using the valid legacy pinmux container node
will be actively rejected by dtbs_check because pinmux does not match
-pins$ and is not explicitly defined in the schema.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923062746.516666-1-quchaosheng000406@163.com?part=1