Re: [PATCH v2 2/3] regulator: Add RPMI voltage service

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Build Failure
--

commit 6effdf04903f1a405d2def7e8745701a7d1522d8
Author: Joshua Yeong <joshua.yeong@starfivetech.com>

regulator: Add RPMI voltage service

This commit adds a mailbox client based regulator driver for the RISC-V RPMI
voltage service group. The driver enumerates the voltage domains advertised
by the platform microcontroller and registers each of them as a regulator.

> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 7d151433747be..8ad4159a8bcfe 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -1274,6 +1274,19 @@ config REGULATOR_RC5T583
>  	  through regulator interface. The device supports multiple DCDC/LDO
>  	  outputs which can be controlled by i2c communication.
>  
> +config REGULATOR_RISCV_RPMI
> +	tristate "RISC-V RPMI based regulator driver"
> +	depends on MAILBOX || COMPILE_TEST

[Severity: Medium]
Will this cause a build failure when COMPILE_TEST is enabled but MAILBOX is
disabled?

The driver directly calls mailbox subsystem functions like
mbox_request_channel(), mbox_send_message(), and mbox_free_channel(). Since
include/linux/mailbox_client.h does not provide dummy stubs for these
functions when CONFIG_MAILBOX is disabled, compiling this driver without
the mailbox subsystem results in undefined reference linker errors.

Should the dependency be strictly depends on MAILBOX, or perhaps conditional
based on architecture but retaining the strict mailbox dependency?

> +	default RISCV
> +	help

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923070014.1340761-2-joshua.yeong@starfivetech.com?part=2