Re: [PATCH] dt-bindings: mfd: rockchip,rk805: Convert pinctrl to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: schema validation bypass in pinmux node
--

commit 3e9f0dec3f740f3763a3ebb688af0f850b47bc2f
Author: Quchaosheng <quchaosheng000406@163.com>

    dt-bindings: mfd: rockchip,rk805: Convert pinctrl to DT schema
    
    pinctrl-rk805.txt describes the pinmux controller that is part of the
    Rockchip RK805 PMIC. The PMIC itself is already described by
    rockchip,rk805.yaml, so the pinmux part belongs there as well: the
    pinctrl node is a child of the PMIC node, not a separate device.

    Link: https://sashiko.dev/#/patchset/20260923034245.396417-1-quchaosheng000406@163.com?part=1
    Link: https://sashiko.dev/#/patchset/20260923062746.516666-1-quchaosheng000406@163.com?part=1

> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> index da2391530c16c..aafc80212c485 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> @@ -77,6 +77,21 @@ properties:
>      description:
>        The input supply for LDO_REG3.
>  
> +  # pinctrl-bindings.txt allows the pin configuration nodes to be grandchildren
> +  # of the pin controller, and the text binding this replaces used that layout:
> +  # a "pinmux" node holding the nodes that carry "pins". The driver reaches both
> +  # layouts, because pinconf_generic_dt_node_to_map() parses the referenced node
> +  # and then walks its children.
> +  pinmux:
> +    type: object
> +    additionalProperties: false
> +    patternProperties:
> +      '^.+$':
> +        if:
> +          type: object
> +        then:
> +          $ref: '#/$defs/rk805-pin-config'

[Severity: Medium]
Does this catch-all regex bypass schema validation for all non-object
properties within the grouping node?

The pinmux grouping node in the schema attempts to reject invalid properties
using additionalProperties: false, but its patternProperties regex '^.+$'
combined with if: type: object without an else: false clause evaluates to true
for all non-object properties.

This defeats the strictness of the schema, allowing any arbitrary misspelled or
invalid non-object property (like typo = <1>;) to pass validation silently.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923074337.575122-1-quchaosheng000406@163.com?part=1