Re: [PATCH v4] dt-bindings: mfd: rockchip,rk805: Convert pinctrl to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: schema validation bypass in pinmux node
--

commit 23fc579859b9d9440daa6190b6669884929fe260
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: mfd: rockchip,rk805: Convert pinctrl to DT schema

This commit folds the pinmux description from a text binding into the
rockchip,rk805.yaml schema. It adds child node schema definitions to describe
pin configuration nodes, supporting both flat and grouped layouts.

Link: https://sashiko.dev/#/patchset/20260923034245.396417-1-quchaosheng000406@163.com?part=1
Link: https://sashiko.dev/#/patchset/20260923062746.516666-1-quchaosheng000406@163.com?part=1

> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> index da2391530c16c..aafc80212c485 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> @@ -77,6 +77,21 @@ properties:
>      description:
>        The input supply for LDO_REG3.
>  
> +  # pinctrl-bindings.txt allows the pin configuration nodes to be grandchildren
> +  # of the pin controller, and the text binding this replaces used that layout:
> +  # a "pinmux" node holding the nodes that carry "pins". The driver reaches both
> +  # layouts, because pinconf_generic_dt_node_to_map() parses the referenced node
> +  # and then walks its children.
> +  pinmux:
> +    type: object
> +    additionalProperties: false
> +    patternProperties:
> +      '^.+$':
> +        if:
> +          type: object
> +        then:
> +          $ref: '#/$defs/rk805-pin-config'

[Severity: Medium]
Does this schema allow arbitrary non-object properties to silently pass
validation?

Because the if: type: object condition lacks an else: false clause, any
property matching the '^.+$' regex that is not an object will evaluate as
valid. Since the property matched patternProperties, it bypasses the
additionalProperties: false check.

Should an else: false clause be added to ensure non-object properties are
properly rejected?

> +
>    regulators:
>      type: object
>      patternProperties:
> @@ -86,6 +101,38 @@ properties:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923074503.575956-1-quchaosheng000406@163.com?part=1