Re: [PATCH] arm64: dts: allwinner: h616: orangepi-zero2w: add 24-pin expansion buttons and IR

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] arm64: dts: unconditionally enabling optional expansion board risks phantom inputs and IRQ storms
--

commit 51b58a06db4b29809dc98ff86ac9cae923d63f7c
Author: Vladnwx <vladnwx@users.noreply.github.com>

arm64: dts: allwinner: h616: orangepi-zero2w: add 24-pin expansion buttons and IR

This commit adds device tree nodes for the LRADC buttons and IR receiver on
the OrangePi Zero 2W. It maps the buttons to KEY_1 and KEY_ENTER and enables
both the LRADC and IR controller hardware.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts
> index ff9b40352a545..1b690e3cd041e 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts
[ ... ]
> @@ -189,3 +190,31 @@ &usbphy {
>  	usb1_vbus-supply = <&reg_vcc5v>;
>  	status = "okay";
>  };
> +
> +/*
> + * Buttons and IR receiver on the optional 24-pin expansion board.
> + * KEY1 -> KEY_1, KEY2 -> KEY_ENTER (LRADC channel 0).
> + */
> +&lradc {
> +	vref-supply = <&reg_vcc3v3>;
> +	status = "okay";

[Severity: High]
Could unconditionally enabling the optional LRADC on the base board cause
phantom key presses? If the 24-pin expansion board is not attached, it seems
the floating LRADC pin could drift into the configured 1.0V/1.6V voltage
thresholds and trigger unexpected button presses for users out of the box.
Should this be enabled via a device tree overlay instead?

> +	wakeup-source;
> +
> +	button-1000 {
[ ... ]
> +	button-1600 {
> +		label = "KEY_ENTER";
> +		linux,code = <KEY_ENTER>;
> +		channel = <0>;
> +		voltage = <1600000>;
> +	};
> +};
> +
> +&ir {
> +	status = "okay";
> +};

[Severity: High]
Does unconditionally enabling the IR receiver risk interrupt storms? If the
optional board is missing, a floating IR RX pin lacking an internal pull-up
might pick up electrical noise and oscillate rapidly. This could severely
degrade system performance. Would it be safer to relegate this to an overlay
rather than the base device tree?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923105208.198-1-anykey196@gmail.com?part=1