Re: [PATCH] dt-bindings: arm: coresight: Allow funnel clocks

[Rob Herring <robh@kernel.org>]

On Wed, Sep 23, 2026 at 11:05:20AM -0500, Rob Herring wrote:
> On Mon, Sep 21, 2026 at 11:37:43PM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] dt-bindings: clock-names schema forbids valid single 'atclk' config
> > --
> > 
> > commit 50eea7a4ef1f09b2ff4cd2b8b69396c108a1c74e
> > Author: Rob Herring (Arm) <robh@kernel.org>
> > 
> > dt-bindings: arm: coresight: Allow funnel clocks
> > 
> > This commit modifies the arm,coresight-static-funnel schema to allow
> > one or two clocks, adding support for the apb_pclk and atclk properties.
> > 
> > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
> > > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
> > > @@ -30,6 +30,16 @@ properties:
> > >    power-domains:
> > >      maxItems: 1
> > >  
> > > +  clocks:
> > > +    minItems: 1
> > > +    maxItems: 2
> > > +
> > > +  clock-names:
> > > +    minItems: 1
> > > +    items:
> > > +      - const: apb_pclk
> > > +      - const: atclk
> > 
> > [Severity: Low]
> > Does this positional item list unintentionally forbid valid single-clock
> > configurations where only atclk is present?
> > 
> > By specifying items as a rigid positional list, the dt-schema validation
> > strictly enforces that if only one clock is provided, its name must exactly
> > match apb_pclk.
> 
> Or name should be omitted... 'minItems: 1' on clock-names can be dropped 
> when applying.

Actually, this matches all the other coresight bindings. So it should be 
kept as-is.

Rob