Re: [PATCH v5 35/42] arm64: dts: qcom: sm8150: Add GCC CX power domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] clk: qcom: sm8150: missing runtime PM support pins CX power domain ON
--

commit acb1efde8c25f0a90d262048322b01fb3721956e
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: sm8150: Add GCC CX power domain

This commit adds the CX power domain reference to the GCC node in the sm8150
device tree. This allows GCC GDSC consumers to propagate their votes to the
RPMh CX domain.

> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 94a3b02cb2897..397c0142ea579 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -913,6 +913,7 @@ gcc: clock-controller@100000 {
>  				      "sleep_clk";
>  			clocks = <&rpmhcc RPMH_CXO_CLK>,
>  				 <&sleep_clk>;
> +			power-domains = <&rpmhpd SM8150_CX>;

[Severity: High]
Does adding this property pin the CX power domain ON indefinitely?

Looking at the gcc-sm8150.c driver, it seems .use_rpm is not set to true in
gcc_sm8150_desc. Because of this, qcom_cc_really_probe() skips calling
devm_pm_runtime_enable() for this device.

When platform_probe() attaches the GCC device to the CX domain, it uses
PD_FLAG_ATTACH_POWER_ON, which powers the domain ON. However, since runtime
PM is never enabled on the GCC device, its disable_depth remains 1, causing
pm_runtime_suspended() to always return false.

Since the genpd core evaluates if all attached devices are suspended before
powering off the domain, it seems genpd_power_off() will never power off the
CX domain here. This regression could prevent the SoC from entering deep
sleep states (power collapse) and cause battery drain.

Does gcc-sm8150.c need .use_rpm = true added to gcc_sm8150_desc so the
device can suspend and the domain can be powered off? 

(Note: this same behavior appears to affect sm8250 as its driver also lacks
.use_rpm = true).

>  		};
>  
>  		gpi_dma0: dma-controller@800000 {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-qcom-tie-cx-to-gcc-v5-0-38732033e5b5@oss.qualcomm.com?part=35