Re: [PATCH v2 2/3] media: dt-bindings: media: nxp, imx8mq-vpu: Remove nxp,imx8mq-vpu

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] dt-bindings: removing deprecated nxp,imx8mq-vpu breaks DT ABI backward compatibility
- [Medium] media: leftover warning for deprecated nxp,imx8mq-vpu prints wrong string
--

commit 3bc65c4891afcd4ded470db943d49d0c8d78f2db
Author: Benjamin Gaignard <benjamin.gaignard@collabora.com>

media: dt-bindings: media: nxp, imx8mq-vpu: Remove nxp,imx8mq-vpu

nxp,imx8mq-vpu has been tagged has deprecated since a while.
After driver clean up it is time to remove it.

> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> index 19528262810a5..69619d2c86fa0 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> @@ -14,12 +14,10 @@ description:
>  
>  properties:
>    compatible:
> -    oneOf:
> -      - const: nxp,imx8mq-vpu
> -        deprecated: true

[Severity: High]
Does removing this deprecated string break backward compatibility for older
DTBs? Devices booting with older Device Tree Binaries that only specify
compatible = "nxp,imx8mq-vpu" will no longer bind to the driver or pass schema
validation.

> -      - const: nxp,imx8mq-vpu-g1
> -      - const: nxp,imx8mq-vpu-g2
> -      - const: nxp,imx8mm-vpu-g1
> +    enum:
> +      - nxp,imx8mq-vpu-g1
> +      - nxp,imx8mq-vpu-g2
> +      - nxp,imx8mm-vpu-g1

[Severity: Medium]
Since the old string is being removed from the driver match table in this
series, could the fallback warning in the hantro driver print the wrong string
or become dead code?

In drivers/media/platform/verisilicon/hantro_drv.c:hantro_probe():

	if (of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu"))
		dev_warn(&pdev->dev, "%s compatible is deprecated\n",
			 match->compatible);

If a device tree uses a fallback string (e.g., "nxp,imx8mq-vpu-g1",
"nxp,imx8mq-vpu"), it will match "nxp,imx8mq-vpu-g1". The
of_device_is_compatible() check for the old string succeeds, but
match->compatible points to "nxp,imx8mq-vpu-g1". The driver then incorrectly
warns that the new "nxp,imx8mq-vpu-g1" compatible is deprecated.

If only the old string is present, the driver fails to probe, making the
warning dead code.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924110825.166238-1-benjamin.gaignard@collabora.com?part=2