Re: [PATCH v3 2/3] media: dt-bindings: media: nxp, imx8mq-vpu: Remove nxp,imx8mq-vpu

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: removing deprecated compatible string breaks ABI validation
--

commit 3baa6281627fab6fa7ca3eb8e9793abf829e4442
Author: Benjamin Gaignard <benjamin.gaignard@collabora.com>

media: dt-bindings: media: nxp, imx8mq-vpu: Remove nxp,imx8mq-vpu

This commit removes the deprecated nxp,imx8mq-vpu compatible string from the
Device Tree binding after driver clean up.

> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> index 19528262810a5..69619d2c86fa0 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> @@ -14,12 +14,10 @@ description:
>  
>  properties:
>    compatible:
> -    oneOf:
> -      - const: nxp,imx8mq-vpu
> -        deprecated: true

[Severity: Medium]
Does removing this compatible string break ABI validation for older hardware
descriptions?

Device Tree bindings describe hardware and are generally considered a stable,
OS-independent ABI. While Linux driver support can be removed during cleanup,
shouldn't the schema retain deprecated compatible strings indefinitely (with
deprecated: true) to preserve backwards compatibility?

Removing it entirely means existing or out-of-tree Device Tree source files
and binaries that still use the nxp,imx8mq-vpu string will fail dtbs_check
schema validation with an undocumented compatible error.

> -      - const: nxp,imx8mq-vpu-g1
> -      - const: nxp,imx8mq-vpu-g2
> -      - const: nxp,imx8mm-vpu-g1
> +    enum:
> +      - nxp,imx8mq-vpu-g1
> +      - nxp,imx8mq-vpu-g2
> +      - nxp,imx8mm-vpu-g1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924130453.196299-1-benjamin.gaignard@collabora.com?part=2