Re: [PATCH v2 1/2] dt-bindings: iio: add: document the MAX34417 Four-Channel High Dynamic Range Power Accumulator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: max34417: arbitrarily restrictive minimum on shunt resistor
--

commit 3650a83bfbfc37f2001988362d1f90e712127acc
Author: Neil Armstrong <neil.armstrong@linaro.org>

dt-bindings: iio: add: document the MAX34417 Four-Channel High Dynamic Range Power Accumulator

Document the Maxim MAX34417 Four-Channel High Dynamic Range Power
Accumulator used to monitor power consumption of portable systems.

> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max34417.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max34417.yaml
> new file mode 100644
> index 0000000000000..058af61cc04e2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max34417.yaml

[ ... ]

> +patternProperties:
> +  "^channel@[0-3]$":
> +    $ref: adc.yaml
> +    type: object
> +    description:
> +      Represents the internal channels of the sensor.
> +
> +    properties:
> +      reg:
> +        items:
> +          - minimum: 0
> +            maximum: 3
> +
> +      label: true
> +
> +      shunt-resistor-micro-ohms:
> +        description:
> +          Value in micro Ohms of the shunt resistor connected between the RS+ and RS- inputs.
> +        minimum: 1000

[Severity: Medium]
Does this minimum set an artificially restrictive lower bound for the
shunt-resistor-micro-ohms property?

Valid hardware configurations could utilize sub-milliohm shunt resistors 
(e.g., 250 or 500 micro-ohms), which would fail device tree validation and
prevent the driver from probing.

> +        maximum: 100000
> +        default: 1000
> +
> +    required:
> +      - reg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-topic-sm8x50-iio-max34417-adc-v2-0-9a0609e72f5c@linaro.org?part=1