Re: [PATCH v2 1/2] dt-bindings: display: panel: Add RAiO RA8875 display controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing <dt-bindings/gpio/gpio.h> in example causes dtc build failure
--

commit 7e01f56671098a8bf49e596e68df147ced833fec
Author: Adam Azuddin <azuddinadam@gmail.com>

dt-bindings: display: panel: Add RAiO RA8875 display controller

This commit introduces a new device tree binding for the RAiO RA8875 TFT
display controller. It documents properties for its SPI interface,
including required supplies and GPIO resets.

> diff --git a/Documentation/devicetree/bindings/display/panel/raio,ra8875.yaml b/Documentation/devicetree/bindings/display/panel/raio,ra8875.yaml
> new file mode 100644
> index 0000000000000..b50fd95c57539
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/raio,ra8875.yaml

[ ... ]

> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel: display@0 {
> +            compatible = "raio,ra8875";
> +            reg = <0>;
> +            spi-max-frequency = <16000000>;
> +            vdd-supply = <&vcc_3v3>;
> +            reset-gpios = <&gpio 25 GPIO_ACTIVE_LOW>;

[Severity: Low]
Does this example fail to compile during the make dt_binding_check target?

The GPIO_ACTIVE_LOW macro is used here without the required header
inclusion. This causes dtc compilation to fail with a syntax error
because the macro remains unexpanded.

Could we include <dt-bindings/gpio/gpio.h> at the beginning of the
example block?

> +
> +            display-timings {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924145400.1385815-1-azuddinadam@gmail.com?part=1