Re: [PATCH v4 3/6] arm: dts: sunplus: add PWM, watchdog and MMC nodes to SP7021 DTSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt: silent removal of pinmux configurations
--

commit 4012754092cc91a0278f9cbf36a5d355b0fbbf57
Author: Andrew Gaylard <ag@ffroot.co.za>

arm: dts: sunplus: add PWM, watchdog and MMC nodes to SP7021 DTSI

Add device nodes for the peripherals that have upstream drivers,
including PWM, watchdog, and eMMC controllers. Move the memory node
from the DTS into the DTSI since the RAM is integrated.

> diff --git a/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi b/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
> index ae9bbe0320b8d..9963501b6a41e 100644
> --- a/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
> +++ b/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi

[ ... ]

> @@ -84,50 +89,10 @@ pctl: pinctrl@100 {
>  			clocks = <&clkc CLK_GPIO>;
>  			resets = <&rstc RST_GPIO>;
>  
> -			emac_pins: pinmux-emac-pins {
> -				sunplus,pins = <
> -					SPPCTL_IOPAD(49,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_CLK_OUT,0)

[Severity: Medium]
Is it intentional to silently drop the pinmux configurations for emac_pins,
emmc_pins, and sdcard_pins here?

There does not appear to be an explanation for this removal in the commit
message. While a follow-up patch ("arm: dts: sunplus: add Tibbo LTPP3G2
board") re-introduces the emmc_pins configuration in the board-specific
file, the emac_pins and sdcard_pins configurations are permanently deleted
without explanation. 

Could the commit message be updated to mention these SoC-level DT
configuration removals?

> -					SPPCTL_IOPAD(44,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_MAC_SMI_MDC,0)
> -					SPPCTL_IOPAD(43,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_MAC_SMI_MDIO,0)
> -					SPPCTL_IOPAD(52,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXEN,0)
> -					SPPCTL_IOPAD(50,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXD0,0)
> -					SPPCTL_IOPAD(51,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXD1,0)
> -					SPPCTL_IOPAD(46,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_CRSDV,0)
> -					SPPCTL_IOPAD(47,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXD0,0)
> -					SPPCTL_IOPAD(48,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXD1,0)
> -					SPPCTL_IOPAD(45,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXER,0)
> -					SPPCTL_IOPAD(59,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXEN,0)
> -					SPPCTL_IOPAD(57,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXD0,0)
> -					SPPCTL_IOPAD(58,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXD1,0)
> -					SPPCTL_IOPAD(54,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_CRSDV,0)
> -					SPPCTL_IOPAD(55,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXD0,0)
> -					SPPCTL_IOPAD(56,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXD1,0)
> -					SPPCTL_IOPAD(53,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXER,0)
> -				>;
> -				sunplus,zerofunc = <
> -					MUXF_L2SW_LED_FLASH0
> -					MUXF_L2SW_LED_FLASH1
> -					MUXF_L2SW_LED_ON0
> -					MUXF_L2SW_LED_ON1
> -					MUXF_DAISY_MODE
> -				>;
> -			};
> -
> -			emmc_pins: pinmux-emmc-pins {
> -				function = "CARD0_EMMC";
> -				groups = "CARD0_EMMC";
> -			};
> -
>  			leds_pins: pinmux-leds-pins {
>  				sunplus,pins = < SPPCTL_IOPAD(0,SPPCTL_PCTL_G_GPIO,0,SPPCTL_PCTL_L_OUT) >;
>  			};
>  
> -			sdcard_pins: pinmux-sdcard-pins {
> -				function = "SD_CARD";
> -				groups = "SD_CARD";
> -				sunplus,pins = < SPPCTL_IOPAD(91, SPPCTL_PCTL_G_GPIO, 0, 0) >;
> -			};
> -

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924152844.81705-1-ag@ffroot.co.za?part=3