Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Petko Manolov" <petko.manolov@konsulko.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
Date: Thu, 24 Sep 2026 18:46:24 +0000	[thread overview]
Message-ID: <20260924184624.B90821F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260924183855.1393302-2-petko.manolov@konsulko.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing 'draeger' in vendor-prefixes.yaml
--

commit 9008bdf7e34160e9c4b4b83e8d008ed19bb9882a
Author: Petko Manolov <petko.manolov@konsulko.com>

dt-bindings: arm: fsl: add Draeger M48 dual-cpu board

M48 is a heterogeneous board made by Draeger that is based on two
independent cpus, that are monitoring each other. One of them is imx6,
the other is Altera SoCFPGA Cyclone 5. The imx6 parts used in M48 are
imx6q and imx6dl, hence the two bindings.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 86876311ec59a..2abcae70f33b8 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -260,6 +260,7 @@ properties:
>                - boundary,imx6q-nitrogen6x
>                - compulab,cm-fx6           # CompuLab CM-FX6
>                - dmo,imx6q-edmqmx6         # Data Modul eDM-QMX6 Board
> +              - draeger,imx6q-m48         # Draeger imx6q variant of M48

[Severity: Low]
Is the draeger vendor prefix documented in vendor-prefixes.yaml?

Adding this compatible string without documenting the vendor prefix causes
schema validation tools like dt_binding_check and dtbs_check to emit
warnings or errors.

>                - ds,imx6q-sbc              # Da Sheng COM-9XX Modules
>                - embest,imx6q-marsboard    # Embest MarS Board i.MX6Dual
>                - emtrion,emcon-mx6         # emCON-MX6D or emCON-MX6Q SoM

[ ... ]

> @@ -458,6 +459,7 @@ properties:
>                - boundary,imx6dl-nit6xlite     # Boundary Devices Nitrogen6 Lite
>                - boundary,imx6dl-nitrogen6x    # Boundary Devices Nitrogen6x
>                - bticino,imx6dl-mamoj      # BTicino i.MX6DL Mamoj
> +              - draeger,imx6dl-m48        # Draeger imx6dl variant of M48

[Severity: Low]
Does this compatible string also require the draeger vendor prefix to be
documented in vendor-prefixes.yaml to prevent schema validation failures?

>                - eckelmann,imx6dl-ci4x10
>                - emtrion,emcon-mx6         # emCON-MX6S or emCON-MX6DL SoM
>                - emtrion,emcon-mx6-avari   # emCON-MX6S or emCON-MX6DL SoM on Avari Base

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924183855.1393302-1-petko.manolov@konsulko.com?part=1

  reply	other threads:[~2026-09-24 18:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 18:38 [PATCH v2 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-09-24 18:38 ` [PATCH v2 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-09-24 18:46   ` sashiko-bot [this message]
2026-09-24 18:38 ` [PATCH v2 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov
2026-09-24 18:57   ` sashiko-bot
2026-09-28 14:31   ` Dinh Nguyen
2026-09-29  7:00     ` Petko Manolov
  -- strict thread matches above, loose matches on Subject: below --
2026-09-29  9:18 [PATCH v2 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-09-29  9:18 ` [PATCH v2 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-09-29  9:24   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924184624.B90821F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=petko.manolov@konsulko.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox