Re: [PATCH 4/5] dt-bindings: display/msm: gpu: Document Mahua GPU/GMU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: display/msm/gpu: missing compatible string in reg constraints block
--

commit 31fba47631141728d25d3c820a8da841bf562a70
Author: Jie Zhang <jie.zhang@oss.qualcomm.com>

dt-bindings: display/msm: gpu: Document Mahua GPU/GMU

Adreno X2-85 GPU found in mahua SoC belongs to the A8x family and
is a smaller variant of X2-90 with fewer slices and smaller internal
memories. Update the dt bindings documentation to describe this GPU
along with it's GMU.

> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index e5efe2d35ddcc..8a103f998dd87 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -452,6 +452,7 @@ allOf:
>                - qcom,adreno-43051401
>                - qcom,adreno-44010000
>                - qcom,adreno-44050a01
> +              - qcom,adreno-44060000

[Severity: Medium]
Does the new compatible string qcom,adreno-44060000 also need to be added
to the earlier conditional block for the A8x GPU family?

Documentation/devicetree/bindings/display/msm/gpu.yaml:allOf.if
  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,adreno-44010000
              - qcom,adreno-44050a01
              - qcom,adreno-44070001
    then:
      properties:
        reg:
          minItems: 2
          maxItems: 2

Without it, the device tree schema will fail to enforce the correct register
count of exactly 2 regions for the new Adreno X2-85 GPU variant when a device
tree node is added with an incorrect number of reg regions. This allows
invalid nodes to silently pass validation.

>                - qcom,adreno-44070001
>  
>      then: # Starting with A6xx, the clocks are usually defined in the GMU node

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-mahua-gpu-v1-0-0fa0bfd8d315@oss.qualcomm.com?part=4