From: sashiko-bot@kernel.org
To: "Adrian Ng Ho Yin" <adrian.ho.yin.ng@altera.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: agilex5: add support for debug daughter card
Date: Fri, 25 Sep 2026 04:24:27 +0000 [thread overview]
Message-ID: <20260925042427.D56591F000FF@smtp.kernel.org> (raw)
In-Reply-To: <3dc20b61d38e.1790308304.git.adrian.ho.yin.ng@altera.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: undefined label usb31 causes build breakage
--
commit 9aa710e27c40d1e631b159f030bd4278c2898e97
Author: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
arm64: dts: agilex5: add support for debug daughter card
This commit adds a new device tree for the Agilex5 SoCDK debug daughter card.
It overrides several peripheral nodes including ethernet, SPI, and USB to
reflect the updated hardware wiring.
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
> new file mode 100644
> index 0000000000000..5c36410128cf3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
[ ... ]
> +&usb31 {
> + dr_mode = "host";
> + status = "okay";
> +};
[Severity: Low]
Will this compile successfully? It looks like usb31 is an undefined label,
which will cause a syntax error (unresolved reference) during device tree
compilation.
The base socfpga_agilex5.dtsi defines the USB controller label as usb0. Should
this node override reference &usb0 instead to prevent the dtbs build from
breaking?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790308304.git.adrian.ho.yin.ng@altera.com?part=2
next prev parent reply other threads:[~2026-09-25 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 4:15 [PATCH v3 0/2] arm64: dts: agilex5: add support for debug daughter card Adrian Ng Ho Yin
2026-09-25 4:15 ` [PATCH v3 1/2] dt-bindings: eeprom: at25: add Microchip 25AA128 Adrian Ng Ho Yin
2026-09-29 8:10 ` Krzysztof Kozlowski
2026-09-25 4:15 ` [PATCH v3 2/2] arm64: dts: agilex5: add support for debug daughter card Adrian Ng Ho Yin
2026-09-25 4:24 ` sashiko-bot [this message]
2026-10-02 12:07 ` (subset) [PATCH v3 0/2] " Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925042427.D56591F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox