Re: [PATCH v3 2/2] ARM: dts: ux500: Use AB8505 charger compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] power: supply: ab8500_charger probe fails on AB8505 due to missing interrupts
--

commit 200a7cf6b0fcab2522c0b09962c1e5a2bbf1cd85
Author: Linus Walleij <linusw@kernel.org>

ARM: dts: ux500: Use AB8505 charger compatible

Identify the AB8505 charger using its variant-specific compatible and
retain the AB8500 compatible as a fallback. Remove the nonexistent AB8500
main charger interrupts from the AB8505 charger node.

> diff --git a/arch/arm/boot/dts/st/ste-ab8505.dtsi b/arch/arm/boot/dts/st/ste-ab8505.dtsi
> index 131c82508e820..4c9a8418f225a 100644
> --- a/arch/arm/boot/dts/st/ste-ab8505.dtsi
> +++ b/arch/arm/boot/dts/st/ste-ab8505.dtsi
> @@ -137,13 +137,9 @@ ab8500_btemp {
>  				};
>  
>  				ab8500_charger {
> -					compatible = "stericsson,ab8500-charger";
> -					interrupts = <10 IRQ_TYPE_LEVEL_HIGH>,
> -						     <11 IRQ_TYPE_LEVEL_HIGH>,
> -						     <0 IRQ_TYPE_LEVEL_HIGH>,
> -						     <107 IRQ_TYPE_LEVEL_HIGH>,
> -						     <106 IRQ_TYPE_LEVEL_HIGH>,
> -						     <14 IRQ_TYPE_LEVEL_HIGH>,
> +					compatible = "stericsson,ab8505-charger",
> +						     "stericsson,ab8500-charger";
> +					interrupts = <14 IRQ_TYPE_LEVEL_HIGH>,

[Severity: High]
Will this cause the probe function to fail on the AB8505 platform?

Looking at ab8500_charger_probe() in drivers/power/supply/ab8500_charger.c,
it unconditionally iterates over the statically sized 14-element
ab8500_charger_irq array:

	for (i = 0; i < ARRAY_SIZE(ab8500_charger_irq); i++) {
		irq = platform_get_irq_byname(pdev, ab8500_charger_irq[i].name);
		if (irq < 0)
			return irq;

Since this patch removes five of these expected interrupts (such as
MAIN_CH_UNPLUG_DET) from the device tree node, platform_get_irq_byname()
will return a negative error code and abort the probe.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-ab8500-charger-dt-v3-0-f80b8d295e2d@kernel.org?part=2