From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, media-ci@linuxtv.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 7/9] arm64: dts: qcom: agatti: Add OPE node
Date: Fri, 25 Sep 2026 09:24:31 +0000 [thread overview]
Message-ID: <20260925092431.E75561F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925-camss-isp-ope-v10-7-2622411034cb@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: overlapping IOMMU Stream IDs between camss and isp_ope nodes
--
commit ce4e88f2447866367f72eb516353f018922e3bed
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>
arm64: dts: qcom: agatti: Add OPE node
Add the Offline Processing Engine (OPE) device tree node for the
Agatti platform (QCM2290). The node describes the six register
regions, clocks, interrupt, interconnects, IOMMU mappings, and OPP table.
OPE is a memory-to-memory block with no board-level dependencies, so
the node is left enabled for all Agatti boards.
> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
> index 590bd2432d85b..69237959adc15 100644
> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
> @@ -1984,6 +1984,83 @@ port@1 {
[ ... ]
> + isp_ope: isp@5c42000 {
> + compatible = "qcom,qcm2290-camss-ope";
[ ... ]
> + iommus = <&apps_smmu 0x800 0x0>,
> + <&apps_smmu 0x820 0x0>,
> + <&apps_smmu 0x840 0x0>;
[Severity: Medium]
Will this cause an IOMMU Stream ID conflict during boot when the devices are
probed?
The sibling camss node in arch/arm64/boot/dts/qcom/agatti.dtsi still claims
these exact same Stream IDs alongside 0x400:
camss {
...
iommus = <&apps_smmu 0x400 0x0>,
<&apps_smmu 0x800 0x0>,
<&apps_smmu 0x820 0x0>,
<&apps_smmu 0x840 0x0>;
...
};
The QCM2290 CAMSS binding allows the camss node to drop the three OPE Stream
IDs and keep only the VFE Stream ID (0x400) when OPE is split out into its own
node.
Since both the isp_ope and camss nodes now claim 0x800, 0x820, and 0x840,
should these IDs be removed from the camss node to prevent the arm-smmu driver
from failing to map multiple distinct devices to the same Stream IDs?
This duplication does not appear to be resolved later in the patch series.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-camss-isp-ope-v10-0-2622411034cb@oss.qualcomm.com?part=7
next prev parent reply other threads:[~2026-09-25 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 9:09 [PATCH v10 0/9] media: qcom: camss: CAMSS Offline Processing Engine support Loic Poulain
2026-09-25 9:09 ` [PATCH v10 1/9] media: qcom: camss: Add V4L2 meta format for CAMSS ISP parameters Loic Poulain
2026-09-25 9:09 ` [PATCH v10 2/9] dt-bindings: media: qcom: Add CAMSS Offline Processing Engine (OPE) Loic Poulain
2026-09-25 9:09 ` [PATCH v10 3/9] dt-bindings: media: qcom,qcm2290-camss-ope: Document shikra compatible Loic Poulain
2026-09-29 8:14 ` Krzysztof Kozlowski
2026-09-25 9:09 ` [PATCH v10 4/9] media: uapi: Add CAMSS ISP configuration definition Loic Poulain
2026-09-25 9:09 ` [PATCH v10 5/9] media: Documentation: uapi: Add qcom-camss ISP params documentation Loic Poulain
2026-10-06 8:19 ` Antoine Bouyer
2026-09-25 9:09 ` [PATCH v10 6/9] media: qcom: camss: Add CAMSS Offline Processing Engine driver Loic Poulain
2026-09-25 9:27 ` sashiko-bot
2026-09-25 9:09 ` [PATCH v10 7/9] arm64: dts: qcom: agatti: Add OPE node Loic Poulain
2026-09-25 9:24 ` sashiko-bot [this message]
2026-09-25 9:09 ` [PATCH v10 8/9] arm64: dts: qcom: shikra: " Loic Poulain
2026-09-25 9:09 ` [PATCH v10 9/9] arm64: defconfig: Enable Qualcomm CAMSS OPE driver Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925092431.E75561F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox